Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dep-mgmt): Update node engine version for nns-dapp #3994

Merged
merged 2 commits into from
Feb 18, 2025
Merged

chore(dep-mgmt): Update node engine version for nns-dapp #3994

merged 2 commits into from
Feb 18, 2025

Conversation

venkkatesh-sekar
Copy link
Member

@venkkatesh-sekar venkkatesh-sekar commented Feb 18, 2025 •
edited
Loading

While the current engine version for nns-dapp is valid, the dapp is built with 18.20.5 which breaks npm audit in some cases.

@github-actions github-actions bot added the chore label Feb 18, 2025
@venkkatesh-sekar venkkatesh-sekar marked this pull request as ready for review February 18, 2025 10:59
@venkkatesh-sekar venkkatesh-sekar requested review from a team as code owners February 18, 2025 10:59
tmu0
tmu0 approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@tmu0 tmu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing 💯

Updating container image to sha256:908c9b2abe0647cd54a2485117c263b0da…
528f67c 
…e4a8aba8f25bc073813b09be9b1d59

Image tag: c8f9b73153fa2b4e7a732c9713d671c35992d7a328cc6728c453ec29b8e4e883
@github-actions GitHub Actions
Copy link
Contributor

Run URL: https://github.com/dfinity/ic/actions/runs/13388965405

New container image: sha256:908c9b2abe0647cd54a2485117c263b0dae4a8aba8f25bc073813b09be9b1d59
New container tag: c8f9b73153fa2b4e7a732c9713d671c35992d7a328cc6728c453ec29b8e4e883

@pr-automation-bot-public pr-automation-bot-public bot requested a review from a team as a code owner February 18, 2025 11:06
@venkkatesh-sekar venkkatesh-sekar added this pull request to the merge queue Feb 18, 2025
Merged via the queue into master with commit 599f19d Feb 18, 2025
30 checks passed
@venkkatesh-sekar venkkatesh-sekar deleted the vsekar/fix-dep-nns-dapp branch February 18, 2025 12:01
@venkkatesh-sekar venkkatesh-sekar mentioned this pull request Feb 19, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 19, 2025
@venkkatesh-sekar
fix(dep-mgmt): Remove legacy node engine version (#4011)
3e29a24 
Leftover from #3994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk basvandijk approved these changes

@mbjorkqvist mbjorkqvist mbjorkqvist approved these changes

@tmu0 tmu0 tmu0 approved these changes

Assignees
No one assigned
Labels
chore @finint @idx @product-security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@venkkatesh-sekar @basvandijk @mbjorkqvist @tmu0