Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crypto): CRP-2646 use dedicated AlgorithmID for vetKD #3997

Merged
merged 4 commits into from
Feb 21, 2025

Conversation

fspreiss
Copy link
Member

Uses a dedicated AlgorithmID for vetKD.

@github-actions github-actions bot added the feat label Feb 18, 2025
@fspreiss fspreiss requested review from altkdf and randombit February 21, 2025 08:11
@fspreiss fspreiss marked this pull request as ready for review February 21, 2025 08:21
@fspreiss fspreiss requested review from a team as code owners February 21, 2025 08:21
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).

To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:

  1. Done.

  2. No canister behavior changes.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).

To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:

  1. Done.

  2. No canister behavior changes.

Copy link
Contributor

@maksymar maksymar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for execution files

Copy link
Contributor

@randombit randombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@andreacerulli andreacerulli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fspreiss fspreiss added this pull request to the merge queue Feb 21, 2025
Merged via the queue into master with commit 9260104 Feb 21, 2025
44 checks passed
@fspreiss fspreiss deleted the franzstefan/CRP-2646-vetkd-algorithm-id branch February 21, 2025 16:41
marko-k0 added a commit that referenced this pull request Feb 21, 2025
github-merge-queue bot pushed a commit that referenced this pull request Feb 22, 2025
…etKD (#4064)

Since #3997 we use a dedicated
AlgorithmID for vetKD. However, the PR missed to use this algorithm ID
also in batch delivery, which led to the long running system test
`//rs/tests/consensus/vetkd:vetkd_key_life_cycle_test` getting broken
(see #4060). This PR fixes this by
using `AlgorithmID::VetKD` also in batch delivery.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants