Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(release-runscript): switch to commit being released when generating proposal texts #4004

Merged
merged 1 commit into from
Feb 18, 2025
Merged

feat(release-runscript): switch to commit being released when generating proposal texts #4004

merged 1 commit into from
Feb 18, 2025

Conversation

anchpop
Copy link
Contributor

@anchpop anchpop commented Feb 18, 2025 •
edited
Loading

This is required because the changelog parts of the bash scripts look at the current text in the unreleased_changes.md files, not the text at the commit specified in the command

Next PR →

@github-actions github-actions bot added the feat label Feb 18, 2025
@anchpop anchpop marked this pull request as ready for review February 18, 2025 16:19
@anchpop anchpop requested a review from a team as a code owner February 18, 2025 16:19
@anchpop anchpop force-pushed the @anchpop/switch-to-commit branch from 9e6368e to e6815ac Compare February 18, 2025 20:38
@anchpop anchpop mentioned this pull request Feb 18, 2025
Merged
@anchpop anchpop enabled auto-merge February 18, 2025 21:25
@anchpop anchpop added this pull request to the merge queue Feb 18, 2025
Merged via the queue into master with commit 37953dc Feb 18, 2025
26 checks passed
@anchpop anchpop deleted the @anchpop/switch-to-commit branch February 18, 2025 22:37
github-merge-queue bot pushed a commit that referenced this pull request Feb 19, 2025
@anchpop
feat(release-runscript): Ask user if they want to retry if a script f…
c311b23 
…ails (#4007)

This prevents a situation where they then need to go annoyingly restart
the whole process

Marked as draft for now to prevent accidental merging until the previous
PR in this chain is merged.

[← Previous PR](#4004)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-dfinity max-dfinity max-dfinity approved these changes

Assignees
No one assigned
Labels
feat @nns-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anchpop @max-dfinity