feat: [MR-609] More eagerly remove replicated state at checkpoint heights #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShuoWangNSL
force-pushed
the
shuo/remove_replicated_state_prev_checkpoint
branch
from
5744373 to
c52b2c0
Compare
ShuoWangNSL
force-pushed
the
shuo/remove_replicated_state_prev_checkpoint
branch
from
c52b2c0 to
7cefc91
Compare
ShuoWangNSL
force-pushed
the
shuo/remove_replicated_state_prev_checkpoint
branch
2 times, most recently
from
004ba13 to
54e5937
Compare
ShuoWangNSL
force-pushed
the
shuo/remove_replicated_state_prev_checkpoint
branch
from
54e5937 to
ec44391
Compare
ShuoWangNSL
force-pushed
the
shuo/remove_replicated_state_prev_checkpoint
branch
from
ec44391 to
06e6393
Compare
ShuoWangNSL
force-pushed
the
shuo/remove_replicated_state_prev_checkpoint
branch
from
c36213e to
9bcad6f
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
…llback (#2454) In #2223, Consensus starts call `remove_inmemory_states_below` with extra heights to keep. This PR logs how Consensus calls this API when it has some extra states to keep. It also logs potential removal candidates of in-memory states at checkpoint heights in #906. The logs will be monitored for a while before any actual more eager removal by #906 happens in production. With the proper protection, getting in-memory states should not fall back to loading checkpoints in normal operation. Therefore, this PR also increases the `state_manager_error_count` if that happens.
ShuoWangNSL
force-pushed
the
shuo/remove_replicated_state_prev_checkpoint
branch
from
9bcad6f to
c7e4d91
Compare
ShuoWangNSL
changed the title
ShuoWangNSL
force-pushed
the
shuo/remove_replicated_state_prev_checkpoint
branch
from
c7e4d91 to
6b20ea4
Compare
schneiderstefan
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close MR-609
After several preparation PRs manage to keep extra in-memory states required for pending CUP,
remove_inmemory_states_belowcan now safely remove in-memory states at previous checkpoint heights.In order to do that, we separate
checkpoints_to_keepandinmemory_states_keepinremove_states_below_impl. As a result,snapshotsandstates_metadataare not in sync anymore. We need to adjust some logic when updating them in state sync andcommit_and_certify.