Introduce API v2 authn_method_metadata_replace #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces the API v2 `authn_method_metadata_replace` method. It replaces the metadata map of an existing `authn_method` of an identity. It will be used in place of the current `update` method. The scope reduction to just `metadata` is there to have a clear separation between security relevant changes to an authn_method (such as modifying the `protection`) and changes not relevant to security (modifying the `alias` entry in the metadata).
przydatek
approved these changes
Dec 22, 2023
src/internet_identity/tests/integration/v2_api/authn_method_metadata.rs
Outdated
Show resolved
Hide resolved
added 4 commits
December 22, 2023 12:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the API v2
authn_method_metadata_replacemethod.It replaces the metadata map of an existing
authn_methodof an identity.It will be used in place of the current
updatemethod. The scope reductionto just
metadatais there to have a clear separation between securityrelevant changes to an authn_method (such as modifying the
protection) andchanges not relevant to security (modifying the
aliasentry in the metadata).