Add event per page #2869
Add event per page #2869
Conversation
|
@LXIF please review |
|
@sea-snake please review |
| @@ -18,6 +18,7 @@ void createSpa(async (connection) => { | |||
| // Figure out if user is trying to add a device. If so, use the anchor from the URL. | |||
| const addDeviceAnchor = getAddDeviceAnchor(); | |||
| if (nonNullish(addDeviceAnchor)) { | |||
| analytics.event("page-add-new-device"); | |||
There was a problem hiding this comment.
Looking at the Plausible API spec and tracking lib, shouldn't this be:
analytics.trackPageview({ url: 'https://identity.ic0.app/device/add' }).
I'm afraid that using custom events instead of pageView events (according to doc a special event type) will cause issues later when we migrate to actual routing.
There was a problem hiding this comment.
I know. I just thought that since we don't know yet the new routes, or even whether there will be new routes for this. It was easier to make events.
Even though the statistics won't be mergeable.
I didn't want to go into the routes discussion yet. We don't even have a plan for Svelte.
There was a problem hiding this comment.
Fair enough, then for now custom events is fine indeed.
There was a problem hiding this comment.
Not idea, but better than nothing
Motivation
Better understand where users land when visiting Internt Identity.
Changes
Tests
No new functionality.
🟡 Some screens were changed