Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Improve signal test coverage #2052

Merged
merged 5 commits into from
Dec 19, 2023

Conversation

Constantin1489
Copy link
Contributor

#2036 (comment)

also weird thing, I dont see the output from sigshutdown_handler() when running pytest, so pytest might be shutting it down in a weird way

@Constantin1489
Copy link
Contributor Author

Constantin1489 commented Dec 19, 2023

What kind of reason did fail my PR (https://github.com/dgtlmoon/changedetection.io/actions/runs/7257771185/job/19772065566)? it's literally just checking the docker log after the container is shut down but the error comes when the CD is running.
Even my test code didn't run yet and is not related to the test-api. 😂😂

@dgtlmoon
Copy link
Owner

What kind of reason did fail my PR (https://github.com/dgtlmoon/changedetection.io/actions/runs/7257771185/job/19772065566)? it's literally just checking the docker log after the container is shut down but the error comes when the CD is running. Even my test code didn't run yet and is not related to the test-api. 😂😂

Dont worry about it, it's some random failure due to timing/slowness waiting for response etc

@dgtlmoon
Copy link
Owner

Current tests pass, can I merge this?

@dgtlmoon dgtlmoon merged commit 0dce3f4 into dgtlmoon:master Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants