Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMT2: fix extractbit with non-const index #8180

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

kroening
Copy link
Member

@kroening kroening commented Feb 3, 2024

This fixes a constant literal in the encoding of extractbit for the case of a non-const index.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This fixes a constant literal in the encoding of extractbit for the case of
a non-const index.
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5bdff46) 79.69% compared to head (7834962) 79.69%.

Files Patch % Lines
src/solvers/smt2/smt2_conv.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8180      +/-   ##
===========================================
- Coverage    79.69%   79.69%   -0.01%     
===========================================
  Files         1680     1680              
  Lines       195256   195257       +1     
===========================================
  Hits        155617   155617              
- Misses       39639    39640       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening marked this pull request as ready for review February 3, 2024 23:59
@martin-cs martin-cs removed their assignment Feb 5, 2024
@kroening kroening merged commit 12660ce into develop Feb 5, 2024
38 of 40 checks passed
@kroening kroening deleted the smt2-extractbit branch February 5, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants