fix: correct detected errors by motatoes and coderabbit

Author: aldoborrero

libs/execution/opentofu_test.go

@@ -1,7 +1,6 @@
 package execution
 
 import (
-	"log"
 	"os"
 	"testing"
 
@@ -30,7 +29,7 @@ func TestExecuteTofuApply(t *testing.T) {
 	defer func(name string) {
 		err := os.RemoveAll(name)
 		if err != nil {
-			log.Fatal(err)
+			panic(err)
 		}
 	}(dir)
 
@@ -47,7 +46,7 @@ func TestExecuteTofuApplyDefaultWorkspace(t *testing.T) {
 	defer func(name string) {
 		err := os.RemoveAll(name)
 		if err != nil {
-			log.Fatal(err)
+			panic(err)
 		}
 	}(dir)
 

libs/license/license.go

@@ -27,7 +27,7 @@ func (l LicenseKeyChecker) Check() error {
 	jsonData, err := json.Marshal(data)
 	if err != nil {
 		slog.Error("Error marshalling JSON for license validation", "error", err)
-		return fmt.Errorf("error marhsalling json for license validation: %v", err)
+		return fmt.Errorf("error marshalling JSON for license validation: %v", err)
 	}
 
 	// Create a new POST request

libs/scheduler/aws.go

@@ -335,7 +335,10 @@ func (fetcher *GithubAwsTokenFetcher) GetIdentityToken() ([]byte, error) {
 	}
 	defer resp.Body.Close()
 	parsed := &TokenResponse{}
-	json.NewDecoder(resp.Body).Decode(parsed)
+	if err := json.NewDecoder(resp.Body).Decode(parsed); err != nil {
+		slog.Error("Failed to decode token response", "error", err)
+		return nil, fmt.Errorf("failed to decode token response: %v", err)
+	}
 
 	slog.Debug("Successfully fetched GitHub identity token")
 	return []byte(parsed.Value), nil

libs/spec/providers.go

@@ -235,7 +235,7 @@ func (v VCSProviderBasic) GetPrService(vcsSpec VcsSpec) (ci.PullRequestService,
 		token := os.Getenv("DIGGER_BITBUCKET_ACCESS_TOKEN")
 		if token == "" {
 			slog.Error("DIGGER_BITBUCKET_ACCESS_TOKEN environment variable not set")
-			return nil, fmt.Errorf("failed to get bitbucket service: GITLAB_TOKEN not specified")
+			return nil, fmt.Errorf("failed to get bitbucket service: DIGGER_BITBUCKET_ACCESS_TOKEN not specified")
 		}
 		slog.Debug("Using Bitbucket PR service")
 		return bitbucket.BitbucketAPI{

libs/storage/plan_storage.go

@@ -101,7 +101,7 @@ func (gps *GithubPlanStorage) StorePlanFile(fileContents []byte, artifactName st
 		slog.Error("Failed to finalize GitHub artifact upload",
 			"error", err,
 			"artifactName", artifactName)
-		return fmt.Errorf("could finalize artefact upload: %v", err)
+		return fmt.Errorf("could finalize artifact upload: %v", err)
 	}
 
 	slog.Info("Successfully stored plan file in GitHub artifacts",