Skip to content

Commit 0e49f41

Browse files
motatoesUtpalJayNadigerZIJ
authored
merge develop into feat/lowlevel-run (#1097)
* Docs - Update feedback.mdx * Docs - Update feedback.mdx * Documentation edits made through Mintlify web editor * Documentation edits made through Mintlify web editor * Documentation edits made through Mintlify web editor * Add actions:write permission to AWS quickstart * Add action permissions to GCP quickstart * Docs: add permissions to plan-persistence page * Docs: add comment-id to workflow file in quickstarts * Update github-actions-and-gcp.mdx --------- Co-authored-by: Utpal Nadiger <nadiger.utpal@gmail.com> Co-authored-by: Igor Zalutski <izalutski@gmail.com>
1 parent 72c3f7d commit 0e49f41

File tree

4 files changed

+21
-4
lines changed

4 files changed

+21
-4
lines changed

docs/features/plan-persistence.mdx

+3
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ Or to use a GCP bucket:
1313
upload-plan-destination: gcp
1414
```
1515

16+
## Permissions
17+
Make sure to set `actions:write` permission in your workflow; otherwise plan storage might fail
18+
1619
## Plan json file naming convention
1720

1821
The location of plan json output file is:

docs/getting-started/github-actions-+-aws.mdx

+3
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,14 @@ on:
3636
required: false
3737
job:
3838
required: true
39+
comment_id:
40+
required: true
3941
jobs:
4042
digger-job:
4143
runs-on: ubuntu-latest
4244
permissions:
4345
contents: write # required to merge PRs
46+
actions: write # required for plan persistence
4447
id-token: write # required for workload-identity-federation
4548
pull-requests: write # required to post PR comments
4649
statuses: write # required to validate combined PR status

docs/getting-started/github-actions-and-gcp.mdx

+8
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,18 @@ on:
3636
required: false
3737
job:
3838
required: true
39+
comment_id:
40+
required: true
3941
jobs:
4042
digger-job:
4143
name: Digger
4244
runs-on: ubuntu-latest
45+
permissions:
46+
contents: write # required to merge PRs
47+
actions: write # required for plan persistence
48+
id-token: write # required for workload-identity-federation
49+
pull-requests: write # required to post PR comments
50+
statuses: write # required to validate combined PR status
4351
steps:
4452
- uses: actions/checkout@v4
4553
- id: 'auth'

docs/readme/feedback.mdx

+7-4
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,15 @@
11
---
2-
title: "Feedback - tell us what is lacking"
2+
title: "Feedback"
33
---
44

55
We are always looking at feedback and suggestions from the community. If something is missing, if you have a feature request, or if something isn't working as it is supposed to,
66
please tell us. We are always keen on thoughts/feedback.
77

8-
Please head over to this page on [github](https:github.com/diggerhq/digger/docs/readme/feedback) and raise a PR to add your feedback with the following syntax
98

10-
{Sl no}.{Name} - [Feedback point](Optionally link corresponding GitHub Issue if it exists}
9+
Head over to [Github](https://github.com/diggerhq/digger/blob/develop/docs/readme/feedback.mdx) and raise a PR to add your feedback below (Optionally link to a github issue if you find it is relevant to your feedback)
1110

12-
1. Utpal Nadiger - [terraform file for the initial configuration to setup S3 & Dynamo DB for state management](https://github.com/diggerhq/digger/issues/206)
11+
## To-do list (Issues, feedback and feature requests)
12+
13+
1. Terraform file for the initial condiguration to setup S3 bucket and dynamo DB for [state management](https://github.com/diggerhq/digger/issues/206).
14+
15+
2. Decouple auth from [frontegg](https://github.com/diggerhq/digger/issues/1074).

0 commit comments

Comments
 (0)