Skip to content

Commit 5f4873a

Browse files
authored
no internal server error in github webhook (#1786)
1 parent d66a68c commit 5f4873a

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

backend/controllers/github.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ func (d DiggerController) GithubAppWebHook(c *gin.Context) {
7777
if *event.Action == "deleted" {
7878
err := handleInstallationDeletedEvent(event)
7979
if err != nil {
80-
c.String(http.StatusInternalServerError, "Failed to handle webhook event.")
80+
c.String(http.StatusAccepted, "Failed to handle webhook event.")
8181
return
8282
}
8383
}
@@ -90,7 +90,7 @@ func (d DiggerController) GithubAppWebHook(c *gin.Context) {
9090
err := handleIssueCommentEvent(gh, event, d.CiBackendProvider)
9191
if err != nil {
9292
log.Printf("handleIssueCommentEvent error: %v", err)
93-
c.String(http.StatusInternalServerError, err.Error())
93+
c.String(http.StatusAccepted, err.Error())
9494
return
9595
}
9696

@@ -99,7 +99,7 @@ func (d DiggerController) GithubAppWebHook(c *gin.Context) {
9999
err := hook(gh, event, d.CiBackendProvider)
100100
if err != nil {
101101
log.Printf("handleIssueCommentEvent post hook error: %v", err)
102-
c.String(http.StatusInternalServerError, err.Error())
102+
c.String(http.StatusAccepted, err.Error())
103103
return
104104
}
105105
}
@@ -108,7 +108,7 @@ func (d DiggerController) GithubAppWebHook(c *gin.Context) {
108108
err := handlePullRequestEvent(gh, event, d.CiBackendProvider)
109109
if err != nil {
110110
log.Printf("handlePullRequestEvent error: %v", err)
111-
c.String(http.StatusInternalServerError, err.Error())
111+
c.String(http.StatusAccepted, err.Error())
112112
return
113113
}
114114
default:

0 commit comments

Comments
 (0)