Skip to content

Commit f8c6fc5

Browse files
committed
fix: remove some log remnant imports from backend code
1 parent 05d5019 commit f8c6fc5

File tree

3 files changed

+10
-16
lines changed

3 files changed

+10
-16
lines changed

backend/bootstrap/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import (
55
"fmt"
66
"html/template"
77
"io/fs"
8-
"log"
98
"log/slog"
109
"net/http"
1110
"os"
@@ -38,7 +37,8 @@ func setupProfiler(r *gin.Engine) {
3837

3938
// Create profiles directory if it doesn't exist
4039
if err := os.MkdirAll("/tmp/profiles", 0755); err != nil {
41-
log.Fatalf("Failed to create profiles directory: %v", err)
40+
slog.Error("Failed to create profiles directory", "error", err)
41+
panic(err)
4242
}
4343

4444
// Start periodic profiling goroutine

backend/tasks/runs_test.go

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package main
22

33
import (
44
"fmt"
5-
"log"
65
"os"
76
"strings"
87
"testing"
@@ -36,22 +35,22 @@ func setupSuite(tb testing.TB) (func(tb testing.TB), *models.Database) {
3635
e := os.Remove(dbName)
3736
if e != nil {
3837
if !strings.Contains(e.Error(), "no such file or directory") {
39-
log.Fatal(e)
38+
panic(e)
4039
}
4140
}
4241

4342
// open and create a new database
4443
gdb, err := gorm.Open(sqlite.Open(dbName), &gorm.Config{})
4544
if err != nil {
46-
log.Fatal(err)
45+
panic(err)
4746
}
4847

4948
// migrate tables
5049
err = gdb.AutoMigrate(&models.Policy{}, &models.Organisation{}, &models.Repo{}, &models.Project{}, &models.Token{},
5150
&models.User{}, &models.ProjectRun{}, &models.GithubAppInstallation{}, &models.VCSConnection{}, &models.GithubAppInstallationLink{},
5251
&models.GithubDiggerJobLink{}, &models.DiggerJob{}, &models.DiggerJobParentLink{}, &models.DiggerRun{}, &models.DiggerRunQueueItem{})
5352
if err != nil {
54-
log.Fatal(err)
53+
panic(err)
5554
}
5655

5756
database := &models.Database{GormDB: gdb}
@@ -63,21 +62,21 @@ func setupSuite(tb testing.TB) (func(tb testing.TB), *models.Database) {
6362
orgName := "testOrg"
6463
org, err := database.CreateOrganisation(orgName, externalSource, orgTenantId)
6564
if err != nil {
66-
log.Fatal(err)
65+
panic(err)
6766
}
6867

6968
// create digger repo
7069
repoName := "test repo"
7170
repo, err := database.CreateRepo(repoName, "", "", "", "", org, "")
7271
if err != nil {
73-
log.Fatal(err)
72+
panic(err)
7473
}
7574

7675
// create test project
7776
projectName := "test project"
7877
_, err = database.CreateProject(projectName, org, repo, false, false)
7978
if err != nil {
80-
log.Fatal(err)
79+
panic(err)
8180
}
8281

8382
models.DB = database

backend/utils/github_test.go

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,11 @@
11
package utils
22

33
import (
4-
"github.com/stretchr/testify/assert"
5-
"log"
64
"os"
75
"testing"
8-
)
96

10-
func init() {
11-
log.SetOutput(os.Stdout)
12-
log.SetFlags(log.Ldate | log.Ltime | log.Lshortfile)
13-
}
7+
"github.com/stretchr/testify/assert"
8+
)
149

1510
func TestGithubCloneWithInvalidTokenThrowsErr(t *testing.T) {
1611
f := func(d string) error { return nil }

0 commit comments

Comments
 (0)