add tests for dynamodb and fix condition when checking if table exists #1402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@motatoes is there anything I can do here to move this PR along? :) |
|
hey @larhauga massive thanks for your contribution, we are a bit behind on reviewing PRs due to working on some enterprise requirements, but we'll catch up soon!! |
motatoes
approved these changes
May 9, 2024
|
Thanks for creating the dynamoDB mock and the mocking interface, great work there ! |
ben-of-codecraft
pushed a commit
to ben-of-codecraft/digger
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes some minor restructure of the dynamodb locking package to enable unit testing to ensure the correct handling.
This should also fix #1324 by not trying to create the table every time.