Skip to content

fix cli token auth #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion backend/middleware/basic.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,23 @@ func HttpBasicApiAuth() gin.HandlerFunc {
return
}

if token == os.Getenv("BEARER_AUTH_TOKEN") {
if strings.HasPrefix(token, "cli:") {
if jobToken, err := CheckJobToken(c, token); err != nil {
c.String(http.StatusForbidden, err.Error())
c.Abort()
return
} else {
setDefaultOrganisationId(c)
c.Set(ACCESS_LEVEL_KEY, jobToken.Type)
}
} else if token == os.Getenv("BEARER_AUTH_TOKEN") {
setDefaultOrganisationId(c)
c.Set(ACCESS_LEVEL_KEY, models.AdminPolicyType)
c.Next()
} else {
c.String(http.StatusForbidden, "Invalid Bearer token")
c.Abort()
return
}
return
}
Expand Down
27 changes: 5 additions & 22 deletions backend/middleware/jwt.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import (
"net/http"
"os"
"strings"
"time"
)

func SetContextParameters(c *gin.Context, auth services.Auth, token *jwt.Token) error {
Expand Down Expand Up @@ -195,30 +194,14 @@ func JWTBearerTokenAuth(auth services.Auth) gin.HandlerFunc {
}

if strings.HasPrefix(token, "cli:") {
var dbToken models.Token

jobToken, err := models.DB.GetJobToken(token)
if jobToken == nil {
c.String(http.StatusForbidden, "Invalid bearer token")
c.Abort()
return
}

if time.Now().After(jobToken.Expiry) {
log.Printf("Token has already expired: %v", err)
c.String(http.StatusForbidden, "Token has expired")
c.Abort()
return
}

if err != nil {
log.Printf("Error while fetching token from database: %v", err)
c.String(http.StatusInternalServerError, "Error occurred while fetching database")
if jobToken, err := CheckJobToken(c, token); err != nil {
c.String(http.StatusForbidden, err.Error())
c.Abort()
return
} else {
c.Set(ORGANISATION_ID_KEY, jobToken.OrganisationID)
c.Set(ACCESS_LEVEL_KEY, jobToken.Type)
}
c.Set(ORGANISATION_ID_KEY, dbToken.OrganisationID)
c.Set(ACCESS_LEVEL_KEY, dbToken.Type)
} else if strings.HasPrefix(token, "t:") {
var dbToken models.Token

Expand Down
29 changes: 29 additions & 0 deletions backend/middleware/middleware.go
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
package middleware

import (
"fmt"
"github.com/diggerhq/digger/backend/models"
"github.com/diggerhq/digger/backend/services"
"github.com/gin-gonic/gin"
"log"
"net/http"
"os"
"time"
)

func GetWebMiddleware() gin.HandlerFunc {
Expand Down Expand Up @@ -50,3 +53,29 @@ func GetApiMiddleware() gin.HandlerFunc {
return nil
}
}

func CheckJobToken(c *gin.Context, token string) (*models.JobToken, error) {
jobToken, err := models.DB.GetJobToken(token)
if jobToken == nil {
c.String(http.StatusForbidden, "Invalid bearer token")
c.Abort()
return nil, fmt.Errorf("invalid bearer token")
}

if time.Now().After(jobToken.Expiry) {
log.Printf("Token has already expired: %v", err)
c.String(http.StatusForbidden, "Token has expired")
c.Abort()
return nil, fmt.Errorf("token has expired")
}

if err != nil {
log.Printf("Error while fetching token from database: %v", err)
c.String(http.StatusInternalServerError, "Error occurred while fetching database")
c.Abort()
return nil, fmt.Errorf("could not fetch cli token")
}

log.Printf("Token: %v access level: %v", jobToken.Value, jobToken.Type)
return jobToken, nil
}
Loading
Loading