From 3ebba596f799fb600ff12ce1b278807700296345 Mon Sep 17 00:00:00 2001 From: motatoes Date: Mon, 24 Mar 2025 18:41:14 +0300 Subject: [PATCH 1/3] patch error while posting comment too large --- cli/pkg/digger/digger.go | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/cli/pkg/digger/digger.go b/cli/pkg/digger/digger.go index b097319b8..f1527b4c6 100644 --- a/cli/pkg/digger/digger.go +++ b/cli/pkg/digger/digger.go @@ -126,13 +126,19 @@ func RunJobs(jobs []orchestrator.Job, prService ci.PullRequestService, orgServic } if allAppliesSuccess == true && reportFinalStatusToBackend == true { + currentJob := jobs[0] + _, jobPrCommentUrl, err := reporter.Flush() if err != nil { log.Printf("error while sending job comments %v", err) - return false, false, fmt.Errorf("error while sending job comments %v", err) + cmt, cmt_err := prService.PublishComment(*currentJob.PullRequestNumber, fmt.Sprintf(":yellow_circle: Warning: failed to post comment for project %v, recieved error: %v.\n\n you may review details in the job logs", currentJob.ProjectName, err)) + if cmt_err != nil { + log.Printf("Error while posting error comment: %v", err) + return false, false, fmt.Errorf("failed to post reporter error comment, aborting. Error: %v", err) + } + jobPrCommentUrl = cmt.Url } - currentJob := jobs[0] projectNameForBackendReporting := currentJob.ProjectName // TODO: handle the apply result summary as well to report it to backend. Possibly reporting changed resources as well // Some kind of generic terraform operation summary might need to be introduced From f16cca38c0d99c99366dede27b21845cd813f8fe Mon Sep 17 00:00:00 2001 From: motatoes Date: Mon, 24 Mar 2025 18:49:31 +0300 Subject: [PATCH 2/3] report --- cli/pkg/digger/digger.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/pkg/digger/digger.go b/cli/pkg/digger/digger.go index f1527b4c6..3f243b40a 100644 --- a/cli/pkg/digger/digger.go +++ b/cli/pkg/digger/digger.go @@ -131,7 +131,7 @@ func RunJobs(jobs []orchestrator.Job, prService ci.PullRequestService, orgServic _, jobPrCommentUrl, err := reporter.Flush() if err != nil { log.Printf("error while sending job comments %v", err) - cmt, cmt_err := prService.PublishComment(*currentJob.PullRequestNumber, fmt.Sprintf(":yellow_circle: Warning: failed to post comment for project %v, recieved error: %v.\n\n you may review details in the job logs", currentJob.ProjectName, err)) + cmt, cmt_err := prService.PublishComment(*currentJob.PullRequestNumber, fmt.Sprintf(":yellow_circle: Warning: failed to post report for project %v, recieved error: %v.\n\n you may review details in the job logs", currentJob.ProjectName, err)) if cmt_err != nil { log.Printf("Error while posting error comment: %v", err) return false, false, fmt.Errorf("failed to post reporter error comment, aborting. Error: %v", err) From a00a988e3350141eeb50671345551331233c5e47 Mon Sep 17 00:00:00 2001 From: motatoes Date: Mon, 24 Mar 2025 19:05:04 +0300 Subject: [PATCH 3/3] fix error --- cli/pkg/digger/digger.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/pkg/digger/digger.go b/cli/pkg/digger/digger.go index 3f243b40a..54d93dd5c 100644 --- a/cli/pkg/digger/digger.go +++ b/cli/pkg/digger/digger.go @@ -131,7 +131,7 @@ func RunJobs(jobs []orchestrator.Job, prService ci.PullRequestService, orgServic _, jobPrCommentUrl, err := reporter.Flush() if err != nil { log.Printf("error while sending job comments %v", err) - cmt, cmt_err := prService.PublishComment(*currentJob.PullRequestNumber, fmt.Sprintf(":yellow_circle: Warning: failed to post report for project %v, recieved error: %v.\n\n you may review details in the job logs", currentJob.ProjectName, err)) + cmt, cmt_err := prService.PublishComment(*currentJob.PullRequestNumber, fmt.Sprintf(":yellow_circle: Warning: failed to post report for project %v, received error: %v.\n\n you may review details in the job logs", currentJob.ProjectName, err)) if cmt_err != nil { log.Printf("Error while posting error comment: %v", err) return false, false, fmt.Errorf("failed to post reporter error comment, aborting. Error: %v", err)