-
Notifications
You must be signed in to change notification settings - Fork 562
fix go sum entries #1920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix go sum entries #1920
Conversation
WalkthroughThe pull request updates dependency versions in multiple Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
backend/go.mod (1)
24-24
: New Dependency Addition:github.com/ktrysmt/go-bitbucket
v0.9.81
A new dependency has been added in this module. Please verify that its functionality is needed, its API is compatible, and that there is no conflict with other Bitbucket-related integrations.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (6)
backend/go.sum
is excluded by!**/*.sum
cli/go.sum
is excluded by!**/*.sum
ee/backend/go.sum
is excluded by!**/*.sum
ee/cli/go.sum
is excluded by!**/*.sum
go.work.sum
is excluded by!**/*.sum
libs/go.sum
is excluded by!**/*.sum
📒 Files selected for processing (4)
backend/go.mod
(4 hunks)cli/go.mod
(5 hunks)ee/backend/go.mod
(5 hunks)ee/cli/go.mod
(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build
🔇 Additional comments (12)
backend/go.mod (4)
124-124
: Dependency Version Bump:github.com/dineshba/tf-summarize
Version updated from v0.3.10 to v0.3.14 (indirect). Ensure that any functionality relying on this package does not break with the new version.
168-168
: Dependency Version Bump:github.com/hashicorp/go-getter
Updated to v1.7.8. Confirm that the semantics (and any minor API differences) are compatible with your existing usage.
187-187
: Dependency Version Bump:github.com/hashicorp/terraform-config-inspect
Version updated to v0.0.0-20250203082807-efaa306e97b4. Please double-check that any needed adjustments (such as handling for new API behaviors) are addressed in your code.
289-296
: Golang.org/x Dependencies Update
The indirect dependencies for packages such asgolang.org/x/crypto
,golang.org/x/net
,golang.org/x/sync
,golang.org/x/sys
,golang.org/x/term
, andgolang.org/x/text
have been updated to their newer versions. These updates are consistent with changes in other modules; however, please verify that no breaking changes were introduced by these updates.cli/go.mod (1)
1-29
: Dependency Consistency in CLI Module
This module’s direct dependencies (shown in the first require block) look unaffected. Ensure that the indirect dependency versions (which are updated in related modules) propagate correctly here. In particular, after these version bumps you should rungo mod tidy
to update the associated go.sum entries.ee/cli/go.mod (2)
1-19
: Module Dependency Alignment for EE CLI
The direct dependency versions in the EE CLI module now match those in other modules (e.g. updated versions for libraries such asgithub.com/stretchr/testify
andgithub.com/spf13/viper
). No discrepancies are immediately visible here.
21-40
: Indirect Dependencies Block Verification
Examine the indirect dependencies block to ensure that updates (for example, for various Azure and Google Cloud SDKs) are consistent. Since the same dependency version updates are applied in other go.mod files, it is important that the indirect dependencies are also in-sync.ee/backend/go.mod (5)
1-8
: Module Declaration and Go Version Update
The module is now declared with Go version 1.22.4. Please confirm that the new Go version is supported across your build and CI environments.
9-23
: Direct Dependency Adjustments
It appears that certain dependencies (e.g.ariga.io/atlas-provider-gorm
) have been removed in this module as intended. Ensure that no parts of your code still rely on the removed package before finalizing the change.
25-55
: Indirect Dependency Block Consistency
Review the large block of indirect dependencies to verify that version updates are aligned with those in the backend and CLI modules. In particular, check that updates to external SDKs—such as those for Azure and Google Cloud—and the version bumps for common packages (like the golang.org/x/* updates) are consistent.
281-288
: Golang.org/x Package Updates Verification
The updates for packages such asgolang.org/x/crypto
,golang.org/x/net
,golang.org/x/sync
,golang.org/x/sys
,golang.org/x/term
, andgolang.org/x/text
are also applied here. As with other modules, double-check that these updates cause no regressions.
310-315
: Go Sum Update Verification
After mass dependency updates like these, it is critical to rungo mod tidy
so that your go.sum entries are regenerated correctly. Please verify that the new entries are committed and that no checksum errors occur during build processes.
fixes #1919
Summary by CodeRabbit