fix/ee release pipelines #1926
fix/ee release pipelines #1926
Conversation
WalkthroughThe pull request updates the EE CLI release workflow by modifying the Changes
Possibly related PRs
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/ee_cli_release.yml(1 hunks)cli/pkg/drift/Provider.go(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Build
- GitHub Check: Build
🔇 Additional comments (1)
.github/workflows/ee_cli_release.yml (1)
33-33:✅ Verification successful
Path updated to reflect the new EE CLI location.
The change correctly points to the new project path for the Enterprise Edition CLI. This is consistent with the PR objective to improve the path name.
🏁 Script executed:
#!/bin/bash # Check if the new path structure exists in the repository if [ -d "./ee/cli/cmd/digger" ]; then echo "✅ The new path './ee/cli/cmd/digger' exists." else echo "❌ Warning: The path './ee/cli/cmd/digger' doesn't exist in the repository." echo "This might cause the workflow to fail." fiLength of output: 137
Verified: EE CLI Path Update is Correct
File:
.github/workflows/ee_cli_release.yml, line 33
The updated project path now correctly points to./ee/cli/cmd/digger, which has been confirmed to exist. This change aligns with the PR objective to update the path for the Enterprise Edition CLI.
| @@ -19,7 +19,7 @@ func (d DriftNotificationProviderBasic) Get(prService ci.PullRequestService) (co | |||
| if slackNotificationUrl != "" { | |||
| notification = SlackNotification{slackNotificationUrl} | |||
| } else { | |||
| return nil, fmt.Errorf("could not identify drift mode, please specify slack or github") | |||
| return nil, fmt.Errorf("could not identify drift mode, please specify slack using env variable INPUT_DRIFT_DETECTION_SLACK_NOTIFICATION_URL") | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Improved error message with specific environment variable.
The error message has been updated to provide clearer guidance on how to configure the Slack notification URL using a specific environment variable. This change enhances user experience by providing actionable information.
However, I notice that the original error message mentioned "slack or github" options, but the new message only mentions Slack. If GitHub is no longer a supported option, this change is correct. If GitHub is still supported, you might want to update the error message to include how to configure GitHub as well.
🏁 Script executed:
#!/bin/bash
# Check if there are any references to GitHub as a drift mode elsewhere in the codebase
echo "Checking for GitHub as a drift notification option in the code..."
rg -i "github.*drift" --type goLength of output: 5358
Action: Update drift mode error message to include GitHub configuration details.
- The error message in
cli/pkg/drift/Provider.go(line 22) currently only instructs users to specify Slack notifications via the environment variableINPUT_DRIFT_DETECTION_SLACK_NOTIFICATION_URL. - Verification confirms that GitHub drift notifications are still referenced and appear to be supported (e.g., through usages of
INPUT_DRIFT_GITHUB_ISSUESand references in files likecli/pkg/github/github.goandee/cli/pkg/drift/provider.go). - Please update the error message to either include guidance on configuring GitHub notifications (for example, by mentioning
INPUT_DRIFT_GITHUB_ISSUES) or clarify that drift mode now supports only Slack, if that change is intentional.
Summary by CodeRabbit