Skip to content

fix/ee release pipelines #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

fix/ee release pipelines #1926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1f7420
improve path name
motatoes Mar 27, 2025
22ce7a4
update slack provider
motatoes Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ee_cli_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
goos: linux
goarch: amd64
goversion: 1.21.1
project_path: ./cli/cmd/digger
project_path: ./ee/cli/cmd/digger
binary_name: digger
pre_command: export CGO_ENABLED=0
ldflags: ${{ matrix.ldflags }}
Expand Down
2 changes: 1 addition & 1 deletion cli/pkg/drift/Provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ func (d DriftNotificationProviderBasic) Get(prService ci.PullRequestService) (co
if slackNotificationUrl != "" {
notification = SlackNotification{slackNotificationUrl}
} else {
return nil, fmt.Errorf("could not identify drift mode, please specify slack or github")
return nil, fmt.Errorf("could not identify drift mode, please specify slack using env variable INPUT_DRIFT_DETECTION_SLACK_NOTIFICATION_URL")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Improved error message with specific environment variable.

The error message has been updated to provide clearer guidance on how to configure the Slack notification URL using a specific environment variable. This change enhances user experience by providing actionable information.

However, I notice that the original error message mentioned "slack or github" options, but the new message only mentions Slack. If GitHub is no longer a supported option, this change is correct. If GitHub is still supported, you might want to update the error message to include how to configure GitHub as well.

🏁 Script executed:

#!/bin/bash
# Check if there are any references to GitHub as a drift mode elsewhere in the codebase
echo "Checking for GitHub as a drift notification option in the code..."
rg -i "github.*drift" --type go

Length of output: 5358

Action: Update drift mode error message to include GitHub configuration details.

  • The error message in cli/pkg/drift/Provider.go (line 22) currently only instructs users to specify Slack notifications via the environment variable INPUT_DRIFT_DETECTION_SLACK_NOTIFICATION_URL.
  • Verification confirms that GitHub drift notifications are still referenced and appear to be supported (e.g., through usages of INPUT_DRIFT_GITHUB_ISSUES and references in files like cli/pkg/github/github.go and ee/cli/pkg/drift/provider.go).
  • Please update the error message to either include guidance on configuring GitHub notifications (for example, by mentioning INPUT_DRIFT_GITHUB_ISSUES) or clarify that drift mode now supports only Slack, if that change is intentional.

}
return notification, nil
}
Loading