Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for plugin failing when it is run on a slave agent with error java.lang.IllegalStateException: Jenkins.instance is missing #18

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Siddharth-Srinivas
Copy link
Collaborator

Fixes made:

  • Removed credential reading in the callable where the agent does not have access to the Jenkins instance.
  • Read credentials to be used for the setup in the Agent and pass it down to the callable.
  • PATH setting on remote agents fail gracefully and show a guidance message now to set up manually

Testing done

Verified this works on a Jenkins setup with remote agent. This is the use case where the plugin was failing

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Collaborator

@vinay-mummadi-digicert vinay-mummadi-digicert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants