Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat fast 2 #55

Merged
merged 19 commits into from
Feb 26, 2025
Merged

Feat fast 2 #55

merged 19 commits into from
Feb 26, 2025

Conversation

eveleighoj
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

all files are downloaded one after another, like a giant for loop on top of this each script is ran sequentially to download and concatenate. This makes a first attempt at using multithreaded downloads in python. This is especially effective for tonnes of small downloads.

Related Tickets & Documents

  • Ticket Link
  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] Are there any dependencies on other PRs or Work?

@CarlosCoelhoSL CarlosCoelhoSL marked this pull request as ready for review February 25, 2025 16:40
Copy link
Contributor Author

@eveleighoj eveleighoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some. quick questions. Also we can apply this as a hotfix but mark. another task on the card to write tests before we can class this work as complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants