-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A missing column is not raised as a missing value #329
Comments
Thanks for raising @Swati-Dash - I've popped in our backlog to be prioritised accordingly. I'll keep in touch about when I think we might have resource available once I've chatted when @eveleighoj is back. |
Discussed this with @eveleighoj. Currently the column field log shows which columns exist within the data. This can be compared against the spec. It would be difficult to raise an "issue" against this as issues are set against particular data points, and so enacting this change would result in (potentially) millions of issues being raised which may cause confusion. As a first step, we should look at what the column field log can do via a manual process, or we could bring columns that aren't mapped into the column field log with a new field that shows whether they are in/out of the data provided. Action to discuss further with @Swati-Dash and @greg-slater once SD returns from leave. |
aware of the column field log and manual process of identifying missing columns. Problem is if a LPA has not provided a column the dashboard doesn't flag this ( it shows live/green) so they would not go and add that field. We are asking LPAs to provide data iteratively, how do we help them to see columns are missing on the dashboard? if this can be done via query, its great too. I want to understand why it will raise millions of issues, is it because this will be raised for each resource? |
So in terms of how it displays on the dashboard I think there are wider considerations and you'll need to choose the right approach e.g. a couple of approaches (not saying either are correct):
In in terms of how issues would increase. If a resource was missing a column (and a lot of them are) then for every entry (row) in the resource you would get another issue. so if a resource had 1000 rows and 3 issues at the moment then if we added this in and it was missing a column it would have 1003 issues. If it was missing 2 it would have 2003 issues. You can imagine how this gets massive. In terms of is we need more information in the column-field-log we could potentially add more however we would need to check how everyone is using it right now. We could:
this wouldn't add too many rows but would add a few. I imagine there could be a fair chunk of value though. |
For example in the article-4-direction-area dataset a blank permitted-development-rights field is flagged as a missing-value error but if the column is missing it isn't
The text was updated successfully, but these errors were encountered: