Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonise phase is badly named and hard-codes information which belongs in the specification #357

Open
psd opened this issue Feb 28, 2025 · 0 comments
Assignees
Labels
invalid This doesn't seem right

Comments

@psd
Copy link
Member

psd commented Feb 28, 2025

The harmonise phase introduces the concept of MANDATORY fields. This should be a separate mandatory phase.

There is code which includes dataset names. This is something which should not exist in the pipeline code as it means the feedback we give providers is hard-coded, and supporting new datasets depend on a code change.

The fields which at a minimum are needed to process a dataset could be held in a typology-field dataset.

MANDATORY_FIELDS_DICT = {

@psd psd added the invalid This doesn't seem right label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants