Skip to content

Commit 53e9296

Browse files
committed
update dataset model to include consideration property
1 parent 78d8849 commit 53e9296

File tree

4 files changed

+30
-2
lines changed

4 files changed

+30
-2
lines changed

application/core/models.py

+1
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ class DatasetModel(DigitalLandDateFieldsModel):
9191
attribution_text: str = None
9292
licence: str = None
9393
licence_text: str = None
94+
consideration: str = None
9495

9596

9697
class TypologyModel(DigitalLandDateFieldsModel):

application/db/models.py

+1
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ class DatasetOrm(Base):
107107
themes = Column(ARRAY(Text), nullable=True)
108108
attribution_id = Column(Text, nullable=True)
109109
licence_id = Column(Text, nullable=True)
110+
consideration = Column(Text, nullable=True)
110111

111112
_attribution = relationship(
112113
"AttributionOrm",

application/templates/dataset.html

+3-2
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,7 @@ <h2 class="govuk-heading-s govuk-!-margin-bottom-0" id="specification">
205205
</li>
206206
</ul>
207207
</nav>
208+
{% if dataset['consideration'] %}
208209
<hr class="govuk-section-break govuk-section-break--m">
209210
<h2 class="govuk-heading-s govuk-!-margin-bottom-0" id="data-design">
210211
Designing the data
@@ -213,11 +214,11 @@ <h2 class="govuk-heading-s govuk-!-margin-bottom-0" id="data-design">
213214
<nav role="navigation" aria-labelledby="specification">
214215
<ul class="govuk-list govuk-!-font-size-16">
215216
<li>
216-
<!-- swap ['name'] for ['consideration'] once it is available -->
217-
<a class="govuk-link" href="https://design.planning.data.gov.uk/{{ dataset['name'] }}">{{ dataset['name'] }} planning consideration</a>
217+
<a class="govuk-link" href="https://design.planning.data.gov.uk/planning-consideration/{{ dataset['consideration'] }}">{{ dataset['consideration'] }} planning consideration</a>
218218
</li>
219219
</ul>
220220
</nav>
221+
{% endif %}
221222
</aside>
222223

223224
</div>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
"""add consideration to dataset
2+
3+
Revision ID: 180800810b09
4+
Revises: f9c99b89b3c1
5+
Create Date: 2024-06-26 13:46:25.381348
6+
7+
"""
8+
9+
from alembic import op
10+
import sqlalchemy as sa
11+
12+
13+
# revision identifiers, used by Alembic.
14+
revision = "180800810b09"
15+
down_revision = "f9c99b89b3c1"
16+
branch_labels = None
17+
depends_on = None
18+
19+
20+
def upgrade():
21+
op.add_column("dataset", sa.Column("consideration", sa.Text, nullable=True))
22+
23+
24+
def downgrade():
25+
op.drop_column("dataset", "consideration")

0 commit comments

Comments
 (0)