Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding json response for 410 when triggered with extension .json #255

Merged
merged 5 commits into from
Apr 30, 2024

Conversation

ssadhu-sl
Copy link
Contributor

@ssadhu-sl ssadhu-sl commented Apr 24, 2024

Reference ticket: https://trello.com/c/MNP2L46O/1405-bug-410-responses

  • Returns status code 410 instead of 200 for 'Entity removed' page
  • Added case for returning json response for 410s when called with .json extension
  • Changed the html page content/design for 410 to match other error pages
  • Updated test cases to reflect the changes

Copy link
Contributor

@CarlosCoelhoSL CarlosCoelhoSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just one small thing :)

CarlosCoelhoSL
CarlosCoelhoSL previously approved these changes Apr 25, 2024
Copy link
Contributor

@eveleighoj eveleighoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you need to write a test to check that 404 are being raised (when you showed your screen it was giving a 500 error)?

@ssadhu-sl ssadhu-sl requested a review from eveleighoj April 29, 2024 09:00
@ssadhu-sl ssadhu-sl merged commit 667cc73 into main Apr 30, 2024
4 checks passed
@ssadhu-sl ssadhu-sl deleted the handling_410s branch April 30, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants