Testing without explicitly setting duckdb

Author: ssadhu-sl

tests/conftest.py

@@ -1,11 +1,9 @@
 import os
 import pytest
-import duckdb
 import boto3
 from testcontainers.localstack import LocalStackContainer
 from botocore.exceptions import ClientError
 
-
 os.environ["AWS_ACCESS_KEY_ID"] = "test"
 os.environ["AWS_SECRET_ACCESS_KEY"] = "test"
 os.environ["AWS_DEFAULT_REGION"] = "eu-west-2"
@@ -14,13 +12,17 @@
 os.environ["PERFORMANCE_BASE_PATH"] = "test/path_perf"
 os.environ["SPECIFICATION_BASE_PATH"] = "test/path_spec"
 os.environ["USE_AWS_CREDENTIAL_CHAIN"] = "false"
+os.environ["DUCKDB_S3_USE_SSL"] = "false"
 
 
 @pytest.fixture(scope="module")
 def localstack_container():
     # Start LocalStack container
     with LocalStackContainer() as localstack:
         # Wait for the service to be ready
+        os.environ[
+            "DUCKDB_S3_ENDPOINT"
+        ] = f"s3.localhost.localstack.cloud:{localstack.get_exposed_port(4566)}"  # noqa
         yield localstack
 
 
@@ -37,19 +39,6 @@ def s3_client(localstack_container):
     return s3
 
 
-@pytest.fixture
-def duckdb_connection(localstack_container):
-    # Set up a DuckDB in-memory database
-    conn = duckdb.connect()
-    # Configure DuckDB to connect to S3 via LocalStack
-    conn.execute(
-        f"SET s3_endpoint = '{localstack_container.get_url().lstrip('http://')}';"  # noqa
-    )
-    conn.execute("SET s3_url_style = 'path';")
-    yield conn
-    conn.close()
-
-
 @pytest.fixture(scope="module")
 def test_dir(request):
     return os.path.dirname(request.module.__file__)

tests/integration/test_main.py

@@ -1,5 +1,4 @@
 from fastapi.testclient import TestClient
-from unittest.mock import patch
 from main import app
 import json
 
@@ -8,7 +7,7 @@
 client = TestClient(app)
 
 
-def test_search_issues(s3_bucket, duckdb_connection):
+def test_search_issues(s3_bucket):
     # Prepare test params
     params = {
         "dataset": "conservation-area",
@@ -17,8 +16,7 @@ def test_search_issues(s3_bucket, duckdb_connection):
     }
 
     # Test the function that interacts with DuckDB and S3 via LocalStack
-    with patch("db.duckdb.connect", return_value=duckdb_connection):
-        response = client.get("/log/issue", params=params)
+    response = client.get("/log/issue", params=params)
 
     # Validate the results from the search
     assert response.status_code == 200
@@ -35,13 +33,12 @@ def test_search_issues(s3_bucket, duckdb_connection):
     )
 
 
-def test_search_issues_no_parameters(duckdb_connection):
+def test_search_issues_no_parameters():
     # Prepare test params
     params = {}
 
     # Test the function that interacts with DuckDB and S3 via LocalStack
-    with patch("db.duckdb.connect", return_value=duckdb_connection):
-        response = client.get("/log/issue", params=params)
+    response = client.get("/log/issue", params=params)
 
     response_json = json.loads(response.content.decode("utf-8"))
     details = response_json.get("detail", [])
@@ -52,17 +49,15 @@ def test_search_issues_no_parameters(duckdb_connection):
     )
 
 
-def test_provision_summary(s3_bucket, duckdb_connection):
+def test_provision_summary(s3_bucket):
     # Prepare test params
     params = {
         "organisation": "local-authority:BDG",
         "offset": 0,
         "limit": 8,
     }
 
-    with patch("db.duckdb.connect", return_value=duckdb_connection):
-        # Test the function that interacts with DuckDB and S3 via LocalStack
-        response = client.get("/performance/provision_summary", params=params)
+    response = client.get("/performance/provision_summary", params=params)
 
     # Validate the results from the search
     assert response.status_code == 200
@@ -75,16 +70,14 @@ def test_provision_summary(s3_bucket, duckdb_connection):
     assert len(response_data) > 0
 
 
-def test_specification(s3_bucket, duckdb_connection):
+def test_specification(s3_bucket):
     # Prepare test params
     params = {
         "offset": 0,
         "limit": 8,
     }
 
-    with patch("db.duckdb.connect", return_value=duckdb_connection):
-        # Test the function that interacts with DuckDB and S3 via LocalStack
-        response = client.get("/specification/specification", params=params)
+    response = client.get("/specification/specification", params=params)
 
     # Validate the results from the search
     assert response.status_code == 200