Skip to content

Commit ca3533e

Browse files
committed
Managed difference in AWS auth between local and AWS with an environment variable
1 parent 7f6eae7 commit ca3533e

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

docker-compose.yml

+6
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,12 @@ services:
3434
DUCKDB_S3_USE_SSL: false
3535
AWS_REGION: eu-west-2
3636
LOGGING_LEVEL: DEBUG
37+
USE_AWS_CREDENTIAL_CHAIN: false
38+
39+
# AWS_ACCESS_KEY_ID: "***"
40+
# AWS_SECRET_ACCESS_KEY: "***"
41+
# AWS_SESSION_TOKEN: "***"
42+
# AWS_CREDENTIAL_EXPIRATION: 2024-11-12T10:51:26Z
3743
restart: on-failure
3844
ports:
3945
- "8000:8000"

src/db.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
collection_bucket = os.environ.get("COLLECTION_BUCKET", "local-collection-data")
88
issues_base_path = os.environ.get("ISSUES_BASE_PATH", 'log/issue')
9+
use_aws_credential_chain = os.environ.get("USE_AWS_CREDENTIAL_CHAIN", 'true').lower() == "true"
910

1011
logger = get_logger(__name__)
1112

@@ -31,8 +32,9 @@ def search_issues(params: IssuesParams):
3132

3233
with duckdb.connect() as conn:
3334
try:
34-
logger.info(conn.execute("CREATE SECRET aws (TYPE S3, PROVIDER CREDENTIAL_CHAIN);").fetchall())
35-
logger.info(conn.execute("FROM duckdb_secrets();").fetchall())
35+
if use_aws_credential_chain:
36+
logger.debug(conn.execute("CREATE SECRET aws (TYPE S3, PROVIDER CREDENTIAL_CHAIN);").fetchall())
37+
logger.debug(conn.execute("FROM duckdb_secrets();").fetchall())
3638
count = conn.execute(sql_count).fetchone()[0] # Count is first item in Tuple
3739
logger.debug(count)
3840
results = conn.execute(sql_results).arrow().to_pylist()

src/schema.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
class IssuesParams(BaseModel):
88
offset: int = Field(0, ge=0)
99
limit: int = Field(50, ge=1, le=100)
10-
dataset: Optional[str] = Field(None)
10+
dataset: str
1111
resource: Optional[str] = Field(None)
1212
field: Optional[str] = Field(None)
1313
issue_type: Optional[str] = Field(None)

0 commit comments

Comments
 (0)