/Specification API #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilwoarH
requested changes
Feb 11, 2025
There was a problem hiding this comment.
do these SQL queries need parameterising?
There was a problem hiding this comment.
yes would definitely prevent SQL Injections. I will make the change.
DilwoarH
requested changes
Feb 11, 2025
|
@DilwoarH We do have an action called Test&Publish which runs after we push on the main branch. We manually trigger the action on other branches before creating a PR. But good call. I will discuss with team in our retro. |
GeorgeGoodall-GovUk
approved these changes
Feb 11, 2025
ssadhu-sl
temporarily deployed
to
development
GitHub Actions
Inactive
DilwoarH
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
New API - /specification for pulling out specification table info from datasette into an API
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
You will need Docker to start the service.
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.
have not been included
[optional] Are there any post deployment tasks we need to perform?
[optional] Are there any dependencies on other PRs or Work?