Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of bounds expectations: details page #958

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rosado
Copy link
Collaborator

@rosado rosado commented Mar 12, 2025

Preview Link

https://submit-pr-958.herokuapp.com/

What type of PR is this? (check all applicable)

  • Refactor
  • Feature

Description

Adds details page for tasks where entities are out of bounds.

Note: the contents of the table on the details page is entity as present dataset's corresponding entity table.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Preview link: local-authority:GRY

Added/updated tests?

  • Yes

QA sign off

  • Code has been checked and approved
  • Design has been checked and approved
  • Product and business logic has been checked and proved

[optional] Are there any post-deployment tasks we need to perform?

[optional] Are there any dependencies on other PRs or Work?

rosado added 2 commits March 12, 2025 13:47
Also includes:
- tweaks to logging - schema errors can easily produce megabytes
  of logs, so we limit that
- refactoring of the pagination code
- update issueDetails.html template to not display the back link
  to "Back to dataset table" - doesn't make sense
Copy link
Contributor

coderabbitai bot commented Mar 12, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Mar 12, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 66.46% 5678 / 8543
🔵 Statements 66.46% 5678 / 8543
🔵 Functions 63.9% 239 / 374
🔵 Branches 79.56% 736 / 925
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
config/util.js 94.28% 80% 100% 94.28% 142-149
src/controllers/OrganisationsController.js 0% 0% 0% 0% 1-27
src/middleware/common.middleware.js 68.94% 92.85% 40.38% 68.94% 30-39, 43, 59-60, 62-63, 75-77, 81, 97-104, 163-174, 180-202, 300, 309-311, 341-343, 381-395, 435-439, 444-447, 459-463, 491-505, 512-523, 529-537, 541-557, 626-628, 701-708, 722-777, 808-809, 812-815, 818-831, 868-871
src/middleware/dataset-failed-expectation-details.middleware.js 0% 0% 0% 0% 1-159
src/middleware/datasetOverview.middleware.js 84.54% 58.53% 33.33% 84.54% 16-36, 77-81, 92-97, 134-136, 207
src/middleware/datasetTaskList.middleware.js 93.54% 80.95% 66.66% 93.54% 128-129, 156-165
src/middleware/lpa-overview.middleware.js 78.48% 69.64% 50% 78.48% 23, 31-33, 40-41, 79-81, 93-95, 101-103, 124-135, 152-154, 164-166, 215-216, 226, 230-231, 267-275, 320-333, 336-348
src/routes/organisations.js 0% 0% 0% 0% 1-23
src/routes/schemas.js 100% 100% 100% 100%
src/serverSetup/errorHandlers.js 0% 0% 0% 0% 1-51
src/utils/custom-renderer.js 97.18% 66.66% 100% 97.18% 21-22
src/utils/pagination.js 95% 93.54% 100% 95% 30-32, 35-37
Generated in workflow #952 for commit 3792075 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Development
Development

Successfully merging this pull request may close these issues.

Display out of bounds results on issues details pages
2 participants