Skip to content

Be more strict and prevent incomplete patterns #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
amitaibu opened this issue May 23, 2023 · 6 comments · May be fixed by #2047
Open

Be more strict and prevent incomplete patterns #1681

amitaibu opened this issue May 23, 2023 · 6 comments · May be fixed by #2047

Comments

@amitaibu
Copy link
Collaborator

Currently, we have the -Wincomplete-patterns flag, which results in easily overlooked warnings.
Can we convert this to a compiler error instead?
@mpscholten
Copy link
Member

In the framework code itself or inside the project's app code?

@amitaibu
Copy link
Collaborator Author

In the framework code, a couple of examples:

image

image

@amitaibu
Copy link
Collaborator Author

But would be useful to have it on the app code as well

@mpscholten
Copy link
Member

For the IHP code itself this then should be done together with #1640

@amitaibu
Copy link
Collaborator Author

Great.

Is it possible meanwhile to have an error just for the app code?

@mpscholten
Copy link
Member

Yes 👍 should be possible. I'd keep this issue open actually, otherwise we might forget about this

@amitaibu amitaibu reopened this May 24, 2023
@amitaibu amitaibu linked a pull request Feb 21, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Be more strict and prevent incomplete patterns digitallyinduced/ihp
2 participants
@amitaibu @mpscholten