Skip to content

[Work In Progress Do Not Merge] New UI #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 21 commits into from
Closed

[Work In Progress Do Not Merge] New UI #534

wants to merge 21 commits into from

Conversation

sravfeyn
Copy link
Member

No description provided.

@Abi-CP
Copy link

Abi-CP commented Mar 28, 2025

Screenshot 2025-03-28 at 6 33 42 PM

The Tailwind setup that you have provided has some sort of issues I guess. The styles for button are overrided by some default style of Tailwind.
The bg-brand-indigo works for span, not for button.

(But it works on our setup with CDN)

The same type of problem is disscussed here Tailwind CSS breaking existing styles

<!-- Vendor dependencies bundled as one file -->
<script src="{% static 'bundles/js/vendors-bundle.js' %}" defer></script>
<script src="{% static 'bundles/js/tailwind-bundle.js' %}" defer></script>
<script src="https://unpkg.com/htmx.org/dist/ext/loading-states.js"></script>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any solution fo this CDN via webpack?

      <script src="https://unpkg.com/htmx.org/dist/ext/loading-states.js"></script>

It raises some error

loading-states.js:62 
Uncaught ReferenceError: htmx is not defined
    at loading-states.js:62:2
    at loading-states.js:183:3
(anonymous) @ loading-states.js:62
(anonymous) @ loading-states.js:183

@@ -0,0 +1,35 @@
{% extends 'tailwind/base.html' %} {% block content %}
<div class="w-full space-y-4">
{% comment %} <div hx-get="src/components/breadcrumb.htmx" hx-trigger="load"></div> {% endcomment %}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@black @Abi-CP It looks like there are still references to src/components from old directory. Further this file doesn't exist.

<div hx-get="src/components/tabs/tabs.ejs" hx-trigger="load"></div>
</div>
<div class="w-full col-span-4">
<div hx-get="src/components/details.ejs" hx-trigger="load"></div>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update these ejs files which shouldn't exist.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkout PR #537, our updates would be reflected there only. This PR is created by your team. We can't modify these files in this PR. And this is an old PR. Kindly use latest branches and PRs for development. Using old PRs may discard our updates.

@sravfeyn sravfeyn closed this May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants