-
Notifications
You must be signed in to change notification settings - Fork 2
Base tailwind table and styling and Opportunity List Table #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
606275e
Base tailwind table and styling
sravfeyn 1af3ef5
Merge branch 'sr/ui-base' into sr/ui-base-table
sravfeyn 388a8e4
Add sorting,pagination to base-table
sravfeyn 30625bc
Implement Opp-list page
sravfeyn 2c507d7
Remove unused pagination file
sravfeyn 8274be5
added opportunity order
hemant10yadav a19d1f2
sidebar URLs
sravfeyn 102542c
Add messages block
sravfeyn 3ac5b82
Merge pull request #572 from dimagi/hy/opp-order
sravfeyn 7e8d4f6
added code review suggestions
hemant10yadav 52cfcf4
added distinct true
hemant10yadav 74df99a
fixed total paid
hemant10yadav e12dfca
removed tooltip
hemant10yadav bd629a3
Merge ui-main
sravfeyn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this performant? just making sure we aren't building something that will get too slow very quickly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's likely this is not performant enough. We are setting aside time to look into this and other places with these kind of queries