Updated Hubspot Request-a-Demo form #35828
Conversation
mjriley
added
the
product/all-users-all-environments
| <input type="text" | ||
| name="company" | ||
| data-bind="textInput: company" | ||
| class="form-control"> |
There was a problem hiding this comment.
| <input type="text" | |
| name="company" | |
| data-bind="textInput: company" | |
| class="form-control"> | |
| <input | |
| class="form-control" | |
| type="text" | |
| name="company" | |
| data-bind="textInput: company" | |
| /> |
| <input type="text" | ||
| name="company" | ||
| data-bind="textInput: jobtitle" | ||
| class="form-control"> |
There was a problem hiding this comment.
https://www.commcarehq.org/styleguide/b5/html/
| <input type="text" | |
| name="company" | |
| data-bind="textInput: jobtitle" | |
| class="form-control"> | |
| <input | |
| class="form-control" | |
| type="text" | |
| name="company" | |
| data-bind="textInput: jobtitle" | |
| /> |
| name="phone" | ||
| data-bind="textInput: phone" | ||
| class="form-control"> | ||
| <select name="language" |
There was a problem hiding this comment.
| data-bind="textInput: skype__c" | ||
| class="form-control"> | ||
| </div> | ||
| <select name="discoverySource" |
There was a problem hiding this comment.
| </label> | ||
| <div class="controls"> | ||
| <input type="text" | ||
| name="preferred_whatsapp_number" | ||
| data-bind="textInput: preferred_whatsapp_number" | ||
| name="otherSource" |
There was a problem hiding this comment.
The comments should be addressed in 3cf6cb3. However, I realize that there is a boostrap5 version of this form that I believe is unused, and I have not incorporated this PRs changes into that form. I tried unsuccessfully to load the bootstrap5 form to verify my changes there. Is there any easy way to handle this, or can we skip the bootstrap5 form for now? |
| }); | ||
|
|
||
| self.isLanguageFieldValid = ko.computed(function () { | ||
| return !self.showPreferredLanguage() || !!self.language__c(); | ||
| self.isDiscoverySourceValid = ko.computed(function () { |
There was a problem hiding this comment.
It looks like this isn't being used anymore.
There was a problem hiding this comment.
Thanks for identifying this bug. The discovery source is a new field, and it was intended to be checked prior to submitting the form. Fixed in 3ed301f
There was a problem hiding this comment.
I'm confused - it looks like c2ce697 intentionally removes the validity check. If you're restoring the validity check, shouldn't you also restore the asterisk so the user knows the field is required?
There was a problem hiding this comment.
you're right :-( reverting (did a force push to remove the commit). e4b028e removes the unnecessary check
| @@ -44,28 +44,15 @@ hqDefine('analytix/js/hubspot', [ | |||
| * Activates the Hubspot Request Demo form | |||
| */ | |||
| _utils.loadDemoForm = function () { | |||
| let isTrial = _get('isDemoTrial'), | |||
| isVariant = _get('demoABv2') && _get('demoABv2').version === 'variant', | |||
There was a problem hiding this comment.
I did not feel comfortable doing this. When I investigated and saw that the test also affects Kissmetrics here, I felt this was outside the scope of this change and required context of what the test was meant to do.
mjriley
force-pushed
the
mjr/demo-form-updates
branch
from
3ed301f to
e4b028e
Compare
…ap3/hubspot_cta_form.html"
Biyeun mentioned the intention was to simply re-run the migration and, because the form was not used, we could leave the TODOs in the code to be handled when the form is eventually moved over to bootstrap 5 |
|
Code looks good, you just need to re-run the B5 diffs. |
Product Description
The requested form on Hubspot:
Our version:
Despite the hubspot version listing the 'how did you hear about us' field as required, marketing is in the process of changing that and wants it to be optional.
Technical Summary
Associated ticket: https://dimagi.atlassian.net/browse/SAAS-16655
Hubspot can handle its own forms, however it appears that previously we intentionally opted against using the hubspot forms because they would get blocked by adblockers. Since the hubspot forms were updated recently, that meant updating the forms manually on our side to align with them.
One important change was the previously, we were maintaining 4 variants of hubspot forms, although only 3 of those variants still exist on the hubspot side. Marketing confirmed that they don't use the other variants and would like us to display the same form in all situations, so I've removed the additional variants and simplified the form.
Feature Flag
No feature flag
Safety Assurance
Safety story
Verified locally that the form displays properly. Verified on hubspot's end that it received the submission I sent locally and that the contact information appears as expected.
Automated test coverage
No tests
QA Plan
No QA
Rollback instructions
Labels & Review