Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated markupsafe to 3.0.2 #35839

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated markupsafe to 3.0.2 #35839

wants to merge 1 commit into from

Conversation

orangejenny
Copy link
Contributor

@orangejenny orangejenny commented Feb 25, 2025 •
edited
Loading

Technical Summary

Last related PR I found, which did a major version update for jinja: #32611

Safety Assurance

Safety story

Release notes aren't concerning, but it's a major version upgrade and touches a lot of parts of HQ.

Automated test coverage

Probably not a ton within the HQ codebase, though we do have some view tests, and QA's automated smoke tests are also relevant.

QA Plan

https://dimagi.atlassian.net/browse/QA-7529

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@orangejenny orangejenny added awaiting QA QA in progress. Do not merge product/invisible Change has no end-user visible impact labels Feb 25, 2025
@orangejenny orangejenny requested a review from a team as a code owner February 25, 2025 02:20
@dimagimon dimagimon added the dependencies Pull requests that update a dependency file label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millerdev millerdev millerdev approved these changes

Assignees
No one assigned
Labels
awaiting QA QA in progress. Do not merge dependencies Pull requests that update a dependency file product/invisible Change has no end-user visible impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orangejenny @millerdev @dimagimon