Issue 774 by Pjohans: Show creator and materialtype on loans-list #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this pull request is connected to |
| @@ -126,10 +126,30 @@ function ding_loan_loans_form($form, &$form_state, $account, $loans = array()) { | |||
| $title = l($entity->getTitle(), $uri['path']); | |||
| } | |||
|
|
|||
| // Add creator(s). | |||
| $creators = $entity->creators; | |||
There was a problem hiding this comment.
This code seams to be the same as in https://github.com/ding2/ding_reservation/pull/10/files would it be possible to move this to an utility function or maybe into an pre-process in ding_base? As the information in both places is used by "material_item" theme function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.