Skip to content

treatment validation (for review) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: remove_treatment_implementation
Choose a base branch
from
Open

treatment validation (for review) #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b5fa998
treatment database migration to generic_assay
dippindots Nov 12, 2019
e0c42ea
remove treatment code
dippindots Nov 13, 2019
7b6994d
remove validation
dippindots Nov 14, 2019
8fcc930
update htmls
dippindots Nov 14, 2019
c6495d4
update treatment remove pr
dippindots Nov 20, 2019
cd57f59
bring treatment validation back
dippindots Nov 20, 2019
f1971dc
update htmls
dippindots Nov 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions core/src/main/java/org/mskcc/cbio/portal/dao/DaoGeneticEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,6 @@ private enum SqlAction {
INSERT, UPDATE, SELECT, DELETE
}

// TODO: consider renaming this class to something something similar to
// DaoEntity
// to reflect the fact that there are also entities that are "not genetic", like
// for example the new entity of type "TREATMENT".
// see: https://github.com/cBioPortal/cbioportal/pull/5460#discussion_r250148672

/**
* Adds a new genetic entity Record to the Database and returns GeneticEntity
*
Expand Down
294 changes: 0 additions & 294 deletions core/src/main/java/org/mskcc/cbio/portal/dao/DaoTreatment.java
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion core/src/main/java/org/mskcc/cbio/portal/model/GeneticAlterationType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,5 @@ public enum GeneticAlterationType {
PROTEIN_ARRAY_PROTEIN_LEVEL,
PROTEIN_ARRAY_PHOSPHORYLATION,
GENESET_SCORE,
TREATMENT,
GENERIC_ASSAY
};
Loading