Skip to content

Fix data migration for already updated 5.0.0 package in djangoCMS 3.11 installations #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,14 @@ Known Issues

When adding a snippet with the `object` or `embed` tag as root element, the CMS toolbar crashes, making any further editing of the page difficult or impossible. A workaround is to just put those elements inside a `div` tag.

**Versioning for djangocms-snippet installations that migrated to version 5.0.0 on django CMS 3.11**

If you are upgrading from a django CMS 3.11 installation to django CMS 4.1 or later, please be aware of the following:

While `djangocms-snippet` includes a migration (``0010_cms4_grouper_version_data_migration``) designed to create initial versions for existing snippets when `djangocms_versioning` is enabled, this migration may not retroactively apply versioning to snippets that existed in a django CMS 3.11 environment if you already migrated to `djangocms-snippet` version 5.0.0.
Therefore, if you are upgrading from a django CMS 3.11 with `djangocms_snippet` already at version 5.0.0, you will currently not be able to enable versioning for your snippets.
This might be fixed in a future release.


Running Tests
-------------
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class Migration(migrations.Migration):
('djangocms_snippet', '0009_auto_20210915_0445'),
]

if djangocms_versioning_installed:
if djangocms_versioning_installed and djangocms_versioning_config_enabled:
dependencies += [('djangocms_versioning', '0015_version_modified'), ]

operations = [
Expand Down