-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ParticleEffectBundle with #[require] for ParticleEffect #419
base: main
Are you sure you want to change the base?
Conversation
All of the examples as well as the readme have been updated to not use or refer to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's not a 1:1 mapping between the bundle ("components which are generally useful") and the require mechanism ("mandatory components").
#[require(CompiledParticleEffect, SyncToRenderWorld)] | ||
#[require( | ||
CompiledParticleEffect, | ||
EffectProperties, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong, properties are optional
#[require( | ||
CompiledParticleEffect, | ||
EffectProperties, | ||
Transform, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong, Transform
is not used.
EffectProperties, | ||
Transform, | ||
GlobalTransform, | ||
Visibility, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think one of those might be wrong, it's not used.
I understand what you mean, I can see how I made these changes without fully thinking it through. (My stance is still that suggesting the use of the |
Completely removes the ParticleEffectBundle struct and replaces it with #[require(...)] for all required components.
All tests succeed after changing the usage to spawning ParticleEffect directly.
fixes #418
(I also attempted to update the inline docs, but cant verify tests since DocTests simply wont run on my machine..)