[WIP] support dependencies as git url (including with exact commit hash) #1403

timotheecour · 2018-03-02T00:03:53Z

[reviewers: please ignore whitespace issues]

this supports for eg:

{
	"fileVersion": 1,
	"versions": {
		"ae": "@https://github.com/timotheecour/ae/commit/64430549f0bad65caa47cef523e69004a2d41b62"
	}
}

this fixes #51 (and is more general since allows that commit to come from a private fork)

also related to #632

it works but I have some question to improve it, please contact me on slack

dlang-bot · 2018-03-02T00:03:54Z

Thanks for your pull request and interest in making D better, @timotheecour! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
I have provided a detailed rationale explaining my changes
New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

timotheecour · 2018-03-04T22:21:47Z

ping @s-ludwig @MartinNowak

s-ludwig · 2018-03-05T07:03:16Z

My main concern is mixin the version string with the git repository. Isn't a git repository really more or less the same as a "path" attribute? The version should usually be inferred from the repository in this case (latest version tag, possibly with commit hash and number appended if more commits were made afterwards).

A case that I think should also be supported is specifying a URL that does not point to a specific commit, and then support version resolution by actually returning all version tags in the package provider.

Another consideration could be to support dropping the schema of the repository URL, so that the best available protocol could be used. But that would just be potentially nice to have.

s-ludwig · 2018-03-05T07:04:39Z

source/dub/dependency.d

@@ -34,6 +34,62 @@ struct PackageDependency {
 	Dependency spec;
 }

+struct GitDep{


Style: Should be fully spelled out (GitDependency) and before { there should always be a single space (or a line break in case of functions).

s-ludwig · 2018-03-05T07:14:31Z

Actually, how about splitting this up into a "repository" part, specified as a separate parameter and without commit hash support, and support for "#2342d3f5a3246" style version strings to specify concrete commits (which may or may not work for other package providers).

Note: I used # here, because I felt that @ might still come in handy for other puposes later, without a concrete idea.

wilzbach · 2018-03-23T16:31:41Z

BTW maybe similar to #1415, git+https:// might be used to avoid ambiguities if support for other versions systems is ever added (or maybe use fetching tar balls from somewhere)

andre2007 · 2018-03-23T19:54:18Z

As far as I know "git+https://..." is also the way you can specify dependencies in Node NPM.
As information URL has currently a small bug with multiple protocols.
I created an issue here #1418. The issue also contains a diff how a possible correction could look like.

wilzbach

Have a look at fetchzip.sh and test_registry.d for a way on how to add tests for this (or #1415's adaption of this).

wilzbach · 2018-03-23T20:06:14Z

source/dub/dependency.d

+		+/
+		assert(spec[0]==Version.hashPrefix);
+		import std.regex;
+    auto m=spec[1..$].matchFirst(`^(.*?)/commit/([a-f0-9]+)$`.regex);


this will compile the regex on every execution. While std.regex now comes with a bit of caching, it's still better to do sth. like

static re = `...`.regex; spec[1..$].matchFirst(re);

wilzbach · 2018-03-23T20:07:27Z

source/dub/dependency.d

@@ -393,6 +459,7 @@ struct Dependency {
 		A specification is valid if it can match at least one version.
 	*/
 	bool valid() const {
+		if(isGit) return true;


Maybe this can be generalized to isHash?

wilzbach · 2018-03-23T20:09:19Z

source/dub/packagesupplier.d

+		URL url = gitDep.toURLZip;
+		logDiagnostic("Downloading from '%s'", url);
+		// TODO: foreach(i; 0..3)
+		download(url, path);


Might be worthwhile to generalize the retry logic in download (almost all supplier seem to require this)

andre2007 · 2018-10-27T11:26:26Z

I am not sure but I think the archive download only works for github and not for bitbucket.
E.g. this doesn't work:
https://bitbucket.org/cybershadow/d/archive/297be750e4725b6cdd4f72b0f2696bf011f34506.zip

I am sure Bitbucket supports s.th. similar but with another URL?
Maybe we should say, if you want to use git dependencies then there should be a git executable in
PATH.

@timotheecour any chance you could continue your work on this topic?

timotheecour · 2018-10-29T18:38:13Z

@andre2007

@timotheecour any chance you could continue your work on this topic?

I've moved on from D to Nim so I don't expect I'll have time to work on this; feel free to take over this PR

support dependencies as git url with exact commit

083b5bd

dlang-bot added the WIP label Mar 2, 2018

timotheecour mentioned this pull request Mar 2, 2018

Allow dependency on specific ~master commit hash #51

Closed

s-ludwig reviewed Mar 5, 2018

View reviewed changes

wilzbach reviewed Mar 23, 2018

View reviewed changes

wilzbach self-assigned this May 6, 2018

timotheecour closed this Oct 29, 2018

wilzbach mentioned this pull request May 10, 2019

Improve DUB user experience dlang/project-ideas#1

Open

belka-ew mentioned this pull request Sep 2, 2019

support dependencies as git url with exact commit #1765

Merged

belka-ew mentioned this pull request Jan 30, 2020

Support dependencies as git url with exact commit #1798

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] support dependencies as git url (including with exact commit hash) #1403

[WIP] support dependencies as git url (including with exact commit hash) #1403

timotheecour commented Mar 2, 2018 •

edited

Loading

dlang-bot commented Mar 2, 2018

timotheecour commented Mar 4, 2018

s-ludwig commented Mar 5, 2018

s-ludwig Mar 5, 2018

s-ludwig commented Mar 5, 2018

wilzbach commented Mar 23, 2018

andre2007 commented Mar 23, 2018

wilzbach left a comment

wilzbach Mar 23, 2018

wilzbach Mar 23, 2018

wilzbach Mar 23, 2018

andre2007 commented Oct 27, 2018 •

edited

Loading

timotheecour commented Oct 29, 2018 •

edited

Loading

[WIP] support dependencies as git url (including with exact commit hash) #1403

[WIP] support dependencies as git url (including with exact commit hash) #1403

Conversation

timotheecour commented Mar 2, 2018 • edited Loading

dlang-bot commented Mar 2, 2018

timotheecour commented Mar 4, 2018

s-ludwig commented Mar 5, 2018

s-ludwig Mar 5, 2018

Choose a reason for hiding this comment

s-ludwig commented Mar 5, 2018

wilzbach commented Mar 23, 2018

andre2007 commented Mar 23, 2018

wilzbach left a comment

Choose a reason for hiding this comment

wilzbach Mar 23, 2018

Choose a reason for hiding this comment

wilzbach Mar 23, 2018

Choose a reason for hiding this comment

wilzbach Mar 23, 2018

Choose a reason for hiding this comment

andre2007 commented Oct 27, 2018 • edited Loading

timotheecour commented Oct 29, 2018 • edited Loading

timotheecour commented Mar 2, 2018 •

edited

Loading

andre2007 commented Oct 27, 2018 •

edited

Loading

timotheecour commented Oct 29, 2018 •

edited

Loading