Reduce N+1

syucream · syucream · commit 706e14e37102 · 2024-09-11T14:42:02.000+09:00
diff --git a/entity/api_v2/serializers.py b/entity/api_v2/serializers.py
@@ -550,7 +550,7 @@ def get_attrs(self, obj: Entity) -> list[EntityDetailAttributeSerializer.EntityD
                 ],
                 "note": x.note,
             }
-            for x in obj.attrs.filter(is_active=True).order_by("index")
+            for x in obj.attrs.filter(is_active=True).prefetch_related("referral").order_by("index")
         ]
 
         # add and remove attributes depending on entity

Original file line number	Diff line number	Diff line change
`@@ -550,7 +550,7 @@ def get_attrs(self, obj: Entity) -> list[EntityDetailAttributeSerializer.EntityD`
`550`	`550`	`],`
`551`	`551`	`"note": x.note,`
`552`	`552`	`}`
`553`		`- for x in obj.attrs.filter(is_active=True).order_by("index")`
	`553`	`+ for x in obj.attrs.filter(is_active=True).prefetch_related("referral").order_by("index")`
`554`	`554`	`]`
`555`	`555`
`556`	`556`	`# add and remove attributes depending on entity`