Skip to content

Commit ced45c3

Browse files
committed
Fixed failed test
1 parent b27c1e6 commit ced45c3

File tree

3 files changed

+15
-6
lines changed

3 files changed

+15
-6
lines changed

CHANGELOG.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
## In development
44

55
### Added
6-
* Added exclude entity parama in search_entries_for_simple.
6+
* Added exclude entity parameter in search_entries_for_simple.
77
Contributed by @hinashi
8-
* Added exclude entity parama in get_referred_objects.
8+
* Added exclude entity parameter in get_referred_objects.
99
Contributed by @hinashi
1010

1111
### Changed

airone/tests/test_elasticsearch.py

+10-3
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ def test_make_query(self):
201201
)
202202

203203
def test_make_query_for_simple(self):
204-
query = elasticsearch.make_query_for_simple("hoge|fuga&1", None, 0)
204+
query = elasticsearch.make_query_for_simple("hoge|fuga&1", None, [], 0)
205205
self.assertEqual(
206206
query,
207207
{
@@ -296,14 +296,21 @@ def test_make_query_for_simple(self):
296296
)
297297

298298
# set hint_entity_name
299-
query = elasticsearch.make_query_for_simple("hoge", "fuga", 0)
299+
query = elasticsearch.make_query_for_simple("hoge", "fuga", [], 0)
300300
self.assertEqual(
301301
query["query"]["bool"]["must"][1],
302302
{"nested": {"path": "entity", "query": {"term": {"entity.name": "fuga"}}}},
303303
)
304304

305+
# set exclude_entity_names
306+
query = elasticsearch.make_query_for_simple("hoge", None, ["fuga"], 0)
307+
self.assertEqual(
308+
query["query"]["bool"]["must_not"][0],
309+
{"nested": {"path": "entity", "query": {"term": {"entity.name": "fuga"}}}},
310+
)
311+
305312
# set offset
306-
query = elasticsearch.make_query_for_simple("hoge", "fuga", 100)
313+
query = elasticsearch.make_query_for_simple("hoge", "fuga", [], 100)
307314
self.assertEqual(query["from"], 100)
308315

309316
def test_make_search_results(self):

api_v1/entry/views.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,8 @@ def get(self, request):
103103
if param_entity:
104104
query &= Q(schema__name=param_entity)
105105

106+
filter_entities = [param_target_entity] if param_target_entity else []
107+
106108
ret_data = []
107109
for entry in Entry.objects.filter(query):
108110
ret_data.append(
@@ -117,7 +119,7 @@ def get(self, request):
117119
if param_quiet
118120
else {"id": x.schema.id, "name": x.schema.name},
119121
}
120-
for x in entry.get_referred_objects(filter_entities=[param_target_entity])
122+
for x in entry.get_referred_objects(filter_entities=filter_entities)
121123
],
122124
}
123125
)

0 commit comments

Comments
 (0)