Revert "Fixed tests that search_results of boolean attribute value is boolean type"

This reverts commit 2043b89.

Author: hinashi

api_v1/tests/entry/test_api.py

@@ -482,34 +482,3 @@ def test_search_with_invalid_entity_param(self):
         resp = self.client.post("/api/v1/entry/search", json.dumps(params), "application/json")
         self.assertEqual(resp.status_code, 400)
         self.assertEqual(resp.content, b'"The entities parameters are required"')
-
-    def test_search_boolean_type_value(self):
-        user = self.guest_login()
-
-        test_entity = self.create_entity(
-            user,
-            "TestEntity",
-            attrs=[
-                {
-                    "name": "boolean",
-                    "type": AttrTypeValue["boolean"],
-                }
-            ],
-        )
-
-        entry = self.add_entry(user, "Entry", test_entity)
-        attr = entry.attrs.last()
-
-        # This checks boolean typed results of advanced search are expected value and expected type
-        for value in [True, False]:
-            attr.add_value(user, value)
-            entry.register_es()
-
-            params = {
-                "entities": [test_entity.id],
-                "attrinfo": [{"name": "boolean"}],
-            }
-            resp = self.client.post("/api/v1/entry/search", json.dumps(params), "application/json")
-            self.assertEqual(
-                resp.json()["result"]["ret_values"][0]["attrs"]["boolean"]["value"], value
-            )

entry/tests/test_api_v2.py

@@ -2222,7 +2222,7 @@ def test_import_create_entry(self):
         self.assertEqual(result["ret_values"][0]["entry"]["name"], "test-entry")
         self.assertEqual(result["ret_values"][0]["entity"]["name"], "test-entity")
         attrs = {
-            "bool": True,
+            "bool": "True",
             "date": "2018-12-31",
             "group": {"id": self.group.id, "name": "group0"},
             "groups": [{"id": self.group.id, "name": "group0"}],
@@ -2267,7 +2267,7 @@ def test_import_update_entry(self):
             "names": [{"foo": {"id": self.ref_entry.id, "name": "r-0"}}],
             "group": {"id": self.group.id, "name": "group0"},
             "groups": [{"id": self.group.id, "name": "group0"}],
-            "bool": True,
+            "bool": "True",
             "text": "foo\nbar",
             "date": "2018-12-31",
             "role": {"id": self.role.id, "name": "role0"},
@@ -2312,7 +2312,7 @@ def test_import_update_entry(self):
             "names": [],
             "group": {"id": "", "name": ""},
             "groups": [],
-            "bool": False,
+            "bool": "False",
             # "text": None,
             "date": None,
             "role": {"id": "", "name": ""},

entry/tests/test_model.py

@@ -2063,7 +2063,7 @@ def test_search_entries(self):
                     self.assertEqual(attrinfo["value"][key]["name"], attrv.referral.name)
 
                 elif attrname == "bool":
-                    self.assertEqual(attrinfo["value"], attrv.boolean)
+                    self.assertEqual(attrinfo["value"], str(attrv.boolean))
 
                 elif attrname == "date":
                     self.assertEqual(attrinfo["value"], str(attrv.date))
@@ -2621,7 +2621,7 @@ def test_register_entry_to_elasticsearch(self):
 
                 elif k == "bool":
                     self.assertEqual(len(value), 1)
-                    self.assertEqual(value[0]["value"], False)
+                    self.assertEqual(value[0]["value"], "False")
 
                 elif k == "date":
                     self.assertEqual(len(value), 1)
@@ -4423,7 +4423,7 @@ def test_get_es_document(self):
                 "value": [ref_entry.name],
                 "referral_id": [ref_entry.id],
             },
-            "bool": {"key": [""], "value": [False], "referral_id": [""]},
+            "bool": {"key": [""], "value": ["False"], "referral_id": [""]},
             "group": {
                 "key": [""],
                 "value": [test_group.name],

entry/tests/test_view.py

@@ -4491,7 +4491,7 @@ def test_revert_attrv(self, mock_task):
 
             value = attr_info[attr_name]["values"][0]
             if data["type"] == AttrTypeValue["boolean"]:
-                self.assertEqual(data["value"], value)
+                self.assertEqual(data["value"], str(value))
 
             elif data["type"] == AttrTypeValue["group"]:
                 self.assertEqual(data["value"], {"name": value.name, "id": value.id})