Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable collecting coverage on the frontend #1061

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Enable collecting coverage on the frontend #1061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0153ce9
Enable collecting coverage on the frontend
syucream Jan 27, 2024
530d77e
Simplify codecov step with existing action
syucream Jan 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/build-core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,9 @@ jobs:
poetry run tox
env:
TOXENV: "py311"
- name: Coverage
run: |
curl -Os https://uploader.codecov.io/latest/linux/codecov
chmod +x codecov
./codecov -t ${CODECOV_TOKEN}
- name: coverage
uses: codecov/codecov-action@v3
with:
token: ${{secrets.CODECOV_TOKEN}}
flags: core
continue-on-error: true
6 changes: 6 additions & 0 deletions .github/workflows/build-frontend.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,9 @@ jobs:
NODE_AUTH_TOKEN: ${{secrets.GITHUB_TOKEN}}
- name: test
run: npm run test
- name: codecov
uses: codecov/codecov-action@v3
with:
token: ${{secrets.CODECOV_TOKEN}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs that owner's operation setting codecov token on GitHub Actions settings. Until the setting, it should fails so I set continue-on-error: true for now.

Copy link
Contributor Author

@syucream syucream Jan 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm it possibly requires administrative operation on codecov side ...? 🤔
#1061 (comment)

flags: ui
continue-on-error: true
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,10 @@ docs/public
# https://qiita.com/knakajima3027/items/f8d10e3066fbcde117d3
static_root

# React
# JavaScript, TypeScript, React
node_modules
static/js/ui.js*
coverage

# local django configuration
airone/settings.py
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"watch:custom": "webpack build --watch --entry ./frontend/src/customview/CustomApp.tsx --mode development",
"lint": "npx eslint frontend && npx prettier --check frontend",
"fix": "npx eslint --fix frontend ; npx prettier --write frontend",
"test": "TZ=UTC npx jest frontend",
"test": "TZ=UTC npx jest --coverage frontend",
"test:update": "TZ=UTC npx jest -u frontend"
},
"repository": {
Expand Down
Loading