Support celery tasks on APIv2 to process heavy operations smoothly #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1094 +/- ##
========================================
Coverage 92.07% 92.08%
========================================
Files 319 319
Lines 27537 27730 +193
Branches 1241 1241
========================================
+ Hits 25356 25534 +178
- Misses 2084 2095 +11
- Partials 97 101 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
syucream
force-pushed
the
feature/api-v2-tasks
branch
from
6fa077a to
8a9734e
Compare
syucream
commented
Mar 8, 2024
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@dmm-com/airone-apiclient-typescript-fetch", | |||
| "version": "0.0.9", | |||
| "version": "0.0.10", | |||
There was a problem hiding this comment.
@userlocalhost @hinashi please update the apiclient package if this PR seems okay.
|
⚡ ⚡ ⚡ Now the latest apiv2 client npm package is available at: |
userlocalhost
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The APIv2 (new UI) handles heavy operations directly, like edit-entry. Its better to separate such operations async tasks on celery, like the current UI.
It supports: