Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make join attr types more type-safe #1353

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Make join attr types more type-safe #1353

merged 1 commit into from
Jan 22, 2025

Conversation

syucream
Copy link
Contributor

  • Introduced new Pydantic models: AdvancedSearchJoinAttrAttrInfo and AdvancedSearchJoinAttrInfo for handling advanced search join attributes.
  • Updated the AdvancedSearchAPI view to utilize the new models for validating and processing join attributes.
  • Refactored code to replace dictionary access with attribute access for improved readability and maintainability.

@syucream
Add advanced search join attribute models and update API view
56c05d6 
- Introduced new Pydantic models: AdvancedSearchJoinAttrAttrInfo and AdvancedSearchJoinAttrInfo for handling advanced search join attributes.
- Updated the AdvancedSearchAPI view to utilize the new models for validating and processing join attributes.
- Refactored code to replace dictionary access with attribute access for improved readability and maintainability.
hinashi
hinashi approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@hinashi hinashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hinashi hinashi merged commit 8571155 into dmm-com:master Jan 22, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hinashi hinashi hinashi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syucream @hinashi