Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finally use published API client package; goodbye repository-owned client! #918

Merged
merged 17 commits into from
Aug 28, 2023

Conversation

syucream
Copy link
Contributor

@syucream syucream commented Aug 19, 2023

At #902, we've finally got published npm package here.
https://github.com/dmm-com/airone/pkgs/npm/airone-apiclient-typescript-fetch/118338298

So, now we can replace code on frontend/src/apiclient/autogenerated which's simple, but painful mechanism with installing @dmm-com/airone-apiclient-typescript-fetch. I do:

  • replace the existing import statements with the published package.
  • describe how to use the new mechanism
  • remove frontend/src/apiclient/autogenerated, goodbye! 👋

As for #834, I also describe how to work/use the mechanism.

@syucream syucream force-pushed the fix/use-npm-package branch from 2c081e1 to 1fca171 Compare August 19, 2023 07:12
@syucream
Copy link
Contributor Author

syucream commented Aug 19, 2023

The failure cause on the build & test jobs is that @dmm-com/airone-apiclient-typescript-fetch@0.0.2 is not the latest. So we need to publish the latest version.
https://github.com/dmm-com/airone/actions/runs/5910330757/job/16031816547?pr=918
https://github.com/dmm-com/airone/actions/runs/5910330757/job/16031816500?pr=918

@@ -1,6 +1,6 @@
{
"name": "@dmm-com/airone-apiclient-typescript-fetch",
"version": "0.0.2",
"version": "0.0.3",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@userlocalhost @hinashi If the changes on this PR looks no problem, then we need to publish the latest client. Plz label release-apiv2-client after the review?

Copy link
Contributor

@hinashi hinashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@syucream
Copy link
Contributor Author

@hinashi Thanks for your catching npm-ci error! I guess we need to modify the workflow definition, so I wanna trying:

  1. modify the workflow defined at master. just merging Enable to install dependencies with GITHUB_TOKEN #927
  2. merge the master branch to this PR
  3. re-labeling to trigger the workflow on this PR

@github-actions
Copy link

⚡ ⚡ ⚡ Now the latest apiv2 client npm package is available at:
https://github.com/dmm-com/airone/pkgs/npm/airone-apiclient-typescript-fetch/versions

@hinashi hinashi merged commit c65ff7b into dmm-com:master Aug 28, 2023
@syucream syucream deleted the fix/use-npm-package branch August 29, 2023 01:49
@syucream
Copy link
Contributor Author

Wow finallyyyyyyy! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants