-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finally use published API client package; goodbye repository-owned client! #918
Conversation
2c081e1
to
1fca171
Compare
The failure cause on the |
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@dmm-com/airone-apiclient-typescript-fetch", | |||
"version": "0.0.2", | |||
"version": "0.0.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@userlocalhost @hinashi If the changes on this PR looks no problem, then we need to publish the latest client. Plz label release-apiv2-client
after the review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@hinashi Thanks for your catching npm-ci error! I guess we need to modify the workflow definition, so I wanna trying:
|
⚡ ⚡ ⚡ Now the latest apiv2 client npm package is available at: |
Wow finallyyyyyyy! 🎉 |
At #902, we've finally got published npm package here.
https://github.com/dmm-com/airone/pkgs/npm/airone-apiclient-typescript-fetch/118338298
So, now we can replace code on
frontend/src/apiclient/autogenerated
which's simple, but painful mechanism with installing@dmm-com/airone-apiclient-typescript-fetch
. I do:frontend/src/apiclient/autogenerated
, goodbye! 👋As for #834, I also describe how to work/use the mechanism.