Skip to content

Commit 899cf1f

Browse files
chensuyuedmsuehir
authored andcommitted
remove continue-on-error: true to stop the test when image build failed (opea-project#608)
Signed-off-by: chensuyue <suyue.chen@intel.com> Signed-off-by: dmsuehir <dina.s.jones@intel.com>
1 parent a978e0f commit 899cf1f

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

.github/workflows/_example-workflow.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ on:
3232
default: false
3333
required: false
3434
type: boolean
35-
GenAIComps_branch:
35+
opea_branch:
3636
default: "main"
3737
required: false
3838
type: string
@@ -46,7 +46,6 @@ jobs:
4646
####################################################################################################
4747
build-images:
4848
runs-on: "docker-build-${{ inputs.node }}"
49-
continue-on-error: true
5049
steps:
5150
- name: Clean Up Working Directory
5251
run: sudo rm -rf ${{github.workspace}}/*
@@ -65,7 +64,7 @@ jobs:
6564
git clone https://github.com/vllm-project/vllm.git
6665
fi
6766
git clone https://github.com/opea-project/GenAIComps.git
68-
cd GenAIComps && git checkout ${{ inputs.GenAIComps_branch }} && cd ../
67+
cd GenAIComps && git checkout ${{ inputs.opea_branch }} && cd ../
6968
7069
- name: Build Image
7170
if: ${{ fromJSON(inputs.build) }}

.github/workflows/manual-example-workflow.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@ on:
4040
description: 'Test examples with k8s'
4141
required: false
4242
type: boolean
43-
GenAIComps_branch:
43+
opea_branch:
4444
default: "main"
45-
description: 'GenAIComps branch for image build'
45+
description: 'OPEA branch for image build'
4646
required: false
4747
type: string
4848
GenAIComps_branch:
@@ -85,5 +85,5 @@ jobs:
8585
scan: ${{ fromJSON(inputs.scan) }}
8686
test_compose: ${{ fromJSON(inputs.test_compose) }}
8787
test_k8s: ${{ fromJSON(inputs.test_k8s) }}
88-
GenAIComps_branch: ${{ inputs.GenAIComps_branch }}
88+
opea_branch: ${{ inputs.opea_branch }}
8989
secrets: inherit

0 commit comments

Comments
 (0)