fix: remove postinstall (#19)

- Couldn't find a script named "babel". - Some type improvements
dnbexperience · Oct 11, 2023 · 3c965e5 · 3c965e5
1 parent 5103d8a
commit 3c965e5
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -28,6 +28,9 @@ jobs:
       - name: Install deps
         run: yarn install --immutable
 
+      - name: Build package
+        run: yarn workspace gatsby-plugin-eufemia-theme-handler build
+
       - name: Set git config
         run: |
           git config --global user.name 'Tobias Høegh'

diff --git a/package.json b/package.json
@@ -13,8 +13,7 @@
     "build": "yarn workspace gatsby-plugin-eufemia-theme-handler build && yarn workspace ui-theme-example build && yarn workspace ui-theme-example serve & yarn workspace sb-theme-example build",
     "serve": "yarn workspace sb-theme-example serve & yarn workspace ui-theme-example serve",
     "clean": "yarn workspace sb-theme-example clean & yarn workspace ui-theme-example clean",
-    "release": "yarn workspace gatsby-plugin-eufemia-theme-handler release",
-    "postinstall": "yarn workspace gatsby-plugin-eufemia-theme-handler build"
+    "release": "yarn workspace gatsby-plugin-eufemia-theme-handler release"
   },
   "devDependencies": {
     "@dnb/eufemia": "10.7.0"

diff --git a/packages/gatsby-plugin-eufemia-theme-handler/package.json b/packages/gatsby-plugin-eufemia-theme-handler/package.json
@@ -46,8 +46,7 @@
     "build:types": "tsc --project tsconfig.json",
     "clean": "rm !(src|babel.config.js|.gitignore|LICENSE|.env|*.md|*.json)",
     "watch": "yarn build --watch",
-    "test:types": "tsc --noEmit",
-    "postinstall": "yarn build"
+    "test:types": "tsc --noEmit"
   },
   "dependencies": {
     "gatsby-core-utils": "4.12.0",

diff --git a/packages/gatsby-plugin-eufemia-theme-handler/src/themeHandler.tsx b/packages/gatsby-plugin-eufemia-theme-handler/src/themeHandler.tsx
@@ -12,11 +12,11 @@ export type ThemesItem = {
   file?: string
   hide?: boolean
   isDev?: boolean
-} & ThemeProps & { name?: ThemeNames }
+} & ThemeProps
 export type Themes = Array<ThemesItem>
 
 const defaultTheme = globalThis.EUFEMIA_THEME_defaultTheme || 'ui'
-const availableThemes = globalThis.EUFEMIA_THEME_themes || []
+const availableThemes = (globalThis.EUFEMIA_THEME_themes || []) as Themes
 const storageId = globalThis.EUFEMIA_THEME_storageId || 'eufemia-theme'
 const availableThemesArray = Object.keys(availableThemes)
 
@@ -74,7 +74,7 @@ export function getTheme(): ThemesItem {
 
 export function setTheme(
   themeProps: { name?: string; propMapping?: PropMapping },
-  callback?
+  callback?: (theme: ThemesItem) => void
 ) {
   const theme = { ...getTheme(), ...themeProps } as ThemesItem