Skip to content

Missing navbar with only coverpage #1696

Closed
@CxRes

Description

@CxRes

Bug Report

Steps to reproduce

  1. Set a navbar loadnavbar: "_nav.md".
  2. Set onlyCover: true

What is current behaviour

The navbar is missing on first navigation to the page.

What is the expected behaviour

The navbar should exist unless set to false.

Other relevant information

If you go to an internal page and and

    • Bug does still occur when all/other plugins are disabled?

    • Your OS: Windows 10 x64

    • Node.js version: 14.17.5

    • npm/yarn version: 6.14.14

    • Browser version: Brave Version 1.33.106 Chromium: 96.0.4664.110 (Official Build) (64-bit)

    • Docsify version: 4.12.1

    • Docsify plugins: NA

Please create a reproducible sandbox

Edit 307qqv236

Sandbox link: https://codesandbox.io/s/elated-sound-6s1rq

Mention the docsify version in which this bug was not present (if any)

Activity

trusktr

trusktr commented on Dec 28, 2021

@trusktr
Member

@CxRes can you please provide a working reproduction? See the codesandbox link above.

trusktr

trusktr commented on Dec 28, 2021

@trusktr
Member

Wait, nvm, i see the second link. The first one pointed to the default sandbox.

trusktr

trusktr commented on Dec 28, 2021

@trusktr
Member

In your reproduction, there is no buttons on the cover page to go to any other page. I believe the expectation is that you will link to a page, then you will see a navbar on that page. Or no?

Does this work on any other sites?

If not, this may be a feature request. We could add an option to show navbar on cover-only pages (defaulting to false to be backward compatible).

PRs welcome!

CxRes

CxRes commented on Dec 28, 2021

@CxRes
Author

@trusktr I added a button in the reproduction. There is no effect.

This is not a feature request! It is a BUG!!!

trusktr

trusktr commented on Dec 31, 2021

@trusktr
Member

I'm not sure if this ever worked. I tried searching github for "onlyCover true" and you can see there are only 5 results and they have a typo (onlycover instead of onlyCover).

We should have this ability regardless if its a bug or not.

trusktr

trusktr commented on Dec 31, 2021

@trusktr
Member

pull request: #1706 (needs a test added for the feature)

locked and limited conversation to collaborators on Dec 31, 2021
jhildenbiddle

jhildenbiddle commented on Jun 16, 2024

@jhildenbiddle
Member

Confirmed working as expected on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Missing navbar with only coverpage · Issue #1696 · docsifyjs/docsify