-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on doctrine/common #300
Comments
That'd be breaking for a lot of bundles that use the current version of this package, bundles that rely on doctrine-common. E.g. Faker uses doctrine-common to abstract the usages of ORM and ODM loaders. |
@shehi that's wrong: all non-deprecated functionality has been extracted into other packages. If any library relies on transitive dependencies (e.g. import doctrine/data-fixtures and expect it to import doctrine/common), this is bad design on their part. We will be phasing out the dependency to doctrine/common in the near future. |
What I meant in general is code like this: https://github.com/fzaninotto/Faker/blob/master/src/Faker/ORM/Doctrine/EntityPopulator.php#L5 which use doctrine/common as abstraction interface in their persistence implementations. This type of lines are everywhere. You will be transitioning them out in doctrine/data-fixtures 1.x or next major release? I am asking just to be 100% sure what you mean. |
This interface has been moved to |
Newer versions od doctrine deprecated doctrine/common package.
Please remove this dependency and depend on new doctrine packages as needed.
The text was updated successfully, but these errors were encountered: