Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup dependabot #475

Merged
merged 2 commits into from
May 5, 2024
Merged

Setup dependabot #475

merged 2 commits into from
May 5, 2024

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented May 5, 2024

No description provided.

@greg0ire
Copy link
Member Author

greg0ire commented May 5, 2024

@derrabus, may I asked what your intent was with #453 ? I believe it's causing the build failure

@greg0ire greg0ire force-pushed the setup-dependabot branch from 0ab6cbe to da7baf7 Compare May 5, 2024 13:17
@derrabus
Copy link
Member

derrabus commented May 5, 2024

I wanted to test against upcoming releases (PHP 8.3, ORM 3, DBAL 4).

@greg0ire
Copy link
Member Author

greg0ire commented May 5, 2024

I believe this is caused by sebastianbergmann/phpunit@63183f2

What should we do?

@derrabus
Copy link
Member

derrabus commented May 5, 2024

Use the workaround?

Let's not use mocks here. My proposal: #476

Tweak config so that the "dev" build only allows dev versions of PHP, and doctrine/*?

In general: I think it's fine if the dev job fails from time to time because of changes upstream.

But we could of course also pin PHPUnit like we do on other repos. Maybe have dependabot bump our tools then?

@greg0ire greg0ire force-pushed the setup-dependabot branch from da7baf7 to 40ef691 Compare May 5, 2024 14:04
@greg0ire
Copy link
Member Author

greg0ire commented May 5, 2024

But we could of course also pin PHPUnit like we do on other repos. Maybe have dependabot bump our tools then?

Sounds like a good idea 👍

@greg0ire greg0ire merged commit 2e8cc3e into doctrine:1.7.x May 5, 2024
21 of 24 checks passed
@greg0ire greg0ire deleted the setup-dependabot branch May 5, 2024 14:09
@greg0ire greg0ire added the CI label May 5, 2024
@greg0ire greg0ire added this to the 1.7.1 milestone May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants